rgw: RGWRESTOp no longer tracks separate error code

[cbodley]

RGWOp_Bucket_Remove::execute() was storing failures from bucket->remove_bucket() in op_ret, but left http_ret=0 so we responded to the client with '200 OK'

to avoid bugs like this, remove the extra http_ret variable and only use the op_ret from RGWOp

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[cbodley]

@mkogan1 this should at least make the admin api for bucket delete return the correct error

[dang]

This seems like a good idea to me. I was just looking at this today.

[mattbenjamin]

can the correct http error code really be inferred from op_ret--esp. in rgw_process(), where there is no context--in all cases though? I've assumed some kind of revised model is maybe needed on RGWOp to deal with this
@cbodley @dang

[cbodley]

can the correct http error code really be inferred from op_ret--esp. in rgw_process(), where there is no context--in all cases though? I've assumed some kind of revised model is maybe needed on RGWOp to deal with this

@mattbenjamin the result we send back to clients is stored in req_state::err. ops call set_req_state_err(s, op_ret); to assign this

note that this change is limited to admin APIs, since they're the only ones that derive from class RGWRESTOp, and just makes them consistent with other RGWOps

[cbodley]

the api test failure shows this working. the -ECANCELED from RGWOp_Bucket_Remove is correctly being returned to the client as a 500 error:

2020-09-08 18:55:45,267.267 INFO:__main__:Traceback (most recent call last):
2020-09-08 18:55:45,267.267 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/test_rgw.py", line 285, in test_all
2020-09-08 18:55:45,267.267 INFO:__main__:    self.assertStatus(204)
2020-09-08 18:55:45,267.267 INFO:__main__:  File "/home/jenkins-build/build/workspace/ceph-api/qa/tasks/mgr/dashboard/helper.py", line 392, in assertStatus
2020-09-08 18:55:45,267.267 INFO:__main__:    self.assertEqual(self._resp.status_code, status)
2020-09-08 18:55:45,268.268 INFO:__main__:AssertionError: 500 != 204

[cbodley]

https://pulpito.ceph.com/cbodley-2020-09-09_12:35:31-rgw-wip-cbodley-testing-distro-basic-smithi/

[cbodley]

rebased over conflict with cls_fifo