mds: only update the requesting metrics #37654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check |
Currently for the MDSs without global metrics needed to be refreshed, the global metric counters will be zero and then after update_rank0, the previous counters in aggregator will be reset. Fixes: https://tracker.ceph.com/issues/47844 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Provide more info in the message.print for metric payloads. Fixes: https://tracker.ceph.com/issues/47844 Signed-off-by: Xiubo Li <xiubli@redhat.com>
It is hard to distinguish which payload it will be without the METRIC_TYPE, for example: 20 handle_payload: mds.metrics: session=0x5639299cdf80, hits=7527, misses=693 20 handle_payload: mds.metrics: session=0x5639299cdf80, hits=2285, misses=120 Fixes: https://tracker.ceph.com/issues/47844 Signed-off-by: Xiubo Li <xiubli@redhat.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for the MDSs without global metrics needed to be refreshed,
the global metric counters will be zero and then after update_rank0,
the previous counters in aggregator will be reset.
Fixes: https://tracker.ceph.com/issues/47844
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox