Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/cephadm: many-to-many Prometheus error #37792

Merged
merged 1 commit into from
Nov 7, 2020
Merged

mgr/cephadm: many-to-many Prometheus error #37792

merged 1 commit into from
Nov 7, 2020

Conversation

p-se
Copy link
Contributor

@p-se p-se commented Oct 26, 2020

Fix configuration created by cephadm to prevent any "many-to-many
matching not allowed: matching labels must be unique on one side"
issues. The mgr/prometheus exporter exports suitable instance labels
itself, which can be taken over when honor_labels in Prometheus is set
to true.

Fixes: https://tracker.ceph.com/issues/47997

Signed-off-by: Patrick Seidensal pseidensal@suse.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@p-se
mgr/cephadm: many-to-many Prometheus error
ea8a3ac 
Fix configuration created by cephadm to prevent any "many-to-many
matching not allowed: matching labels must be unique on one side"
issues. The mgr/prometheus exporter exports suitable instance labels
itself, which can be taken over when `honor_labels` in Prometheus is set
to `true`.

Fixes: https://tracker.ceph.com/issues/47997

Signed-off-by: Patrick Seidensal <pseidensal@suse.com>
@p-se p-se requested review from LenzGr, jan--f, bk201 and a team October 26, 2020 11:57
LenzGr
LenzGr approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the swift fix.

callithea
callithea approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mgfritch
Copy link
Contributor

mgfritch commented Nov 7, 2020

green: https://pulpito.ceph.com/mgfritch-2020-11-06_14:54:25-rados:cephadm-wip-mgfritch-testing-2020-11-05-1314-distro-basic-smithi/

@mgfritch mgfritch merged commit e0fbd49 into ceph:master Nov 7, 2020
@sebastian-philipp sebastian-philipp mentioned this pull request Nov 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenzGr LenzGr LenzGr approved these changes

@mgfritch mgfritch mgfritch approved these changes

@callithea callithea callithea approved these changes

@jan--f jan--f Awaiting requested review from jan--f

@bk201 bk201 Awaiting requested review from bk201

Assignees
No one assigned
Labels
bug-fix cephadm monitoring needs-qa wip-mgfritch-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-se @mgfritch @LenzGr @callithea