nautilus: mgr: don't update osd stat which is already out #38354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ceph status still reports slow requests on the OSD which is already out. When orignal PG monitor handled PGSTATS msg, it wouldn't update osd stat if this OSD is not in OSD map, but current MGR had no checks on that. Fixes: https://tracker.ceph.com/issues/46440 Signed-off-by: Zhi Zhang <zhangz.david@outlook.com> (cherry picked from commit 493ec9d)
tchaikov
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/48400
Ceph status still reports slow requests on the OSD which is already out.
When orignal PG monitor handled PGSTATS msg, it wouldn't update osd stat
if this OSD is not in OSD map, but current MGR had no checks on that.
Fixes: https://tracker.ceph.com/issues/46440
Signed-off-by: Zhi Zhang zhangz.david@outlook.com
(cherry picked from commit 493ec9d)