vstart_runner: print result line unless opt_rotate_log is set

[rishabh-d-dave]

Unless the option to rotate logs is set, don't delete the final result
line printed by unittest.

Without this patch following is how end of vstart_runner.py's output looks -

020-12-03 15:55:57,589.589 INFO:__main__:Stopped test: test_cd_with_args (tasks.cephfs.test_cephfs_shell.TestCD)
Test that when cd is issued with an argument, CWD is changed in 16.692507s
2020-12-03 15:55:57,590.590 INFO:__main__:test_cd_with_args (tasks.cephfs.test_cephfs_shell.TestCD)
2020-12-03 15:55:57,590.590 INFO:__main__:Test that when cd is issued with an argument, CWD is changed ... ok
2020-12-03 15:55:57,591.591 INFO:__main__:> ip netns list
2020-12-03 15:55:57,594.594 INFO:__main__:> sudo ip link delete ceph-brx
Cannot find device "ceph-brx"

This patch restores it to the following -

2020-12-03 16:07:46,570.570 INFO:__main__:test_ls_H_prints_human_readable_file_size (tasks.cephfs.test_cephfs_shell.TestLS)
2020-12-03 16:07:46,570.570 INFO:__main__:Test "ls -lH" prints human readable file size. ... ok
2020-12-03 16:07:46,570.570 INFO:__main__:
2020-12-03 16:07:46,570.570 INFO:__main__:----------------------------------------------------------------------
2020-12-03 16:07:46,570.570 INFO:__main__:Ran 1 test in 18.444s
2020-12-03 16:07:46,570.570 INFO:__main__:
2020-12-03 16:07:46,570.570 INFO:__main__:
2020-12-03 16:07:46,571.571 INFO:__main__:> ip netns list
2020-12-03 16:07:46,574.574 INFO:__main__:> sudo ip link delete ceph-brx
Cannot find device "ceph-brx"
2020-12-03 16:07:46,609.609 INFO:__main__:OK
2020-12-03 16:07:46,610.610 INFO:__main__:

Fixes: https://tracker.ceph.com/issues/48447

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[rishabh-d-dave]

@batrick Just wanted to remind you that vstart_runner.py (i.e. this PR) can't be tested using teuthology.

[batrick]

@batrick Just wanted to remind you that vstart_runner.py (i.e. this PR) can't be tested using teuthology.

I'm aware. I just make sure it builds in shaman then merge.

[rishabh-d-dave]

@batrick Oh, ok. Should I do this too while testing other current and future vstart_runner PRs? I am curious about the purpose it serves since the "make check" CI job already builds binaries for the PR branch.

[batrick]

We've had RPM builds failures on shaman that weren't caught by make check. Excluding documentation only changes, we always should run through shaman before merge.

[rishabh-d-dave]

Okay. thank you for the information.