Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Splitting tenant$user when creating rgw user #38940

Merged
merged 1 commit into from Feb 24, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Jan 18, 2021

Splits the Username field into Tenant and User ID. User can specify tenant and user_id seperately and then click on the generate icon the Username field to generate the username.

Fixes: https://tracker.ceph.com/issues/47378
Signed-off-by: Nizamudeen A nia@redhat.com
BEFORE
rgw_tenant

AFTER
Screencast 2021-02-17 at 13 28 - Ceph

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 requested a review from a team as a code owner January 18, 2021 08:36
@nizamial09 nizamial09 added this to In progress in Dashboard via automation Jan 18, 2021
@nizamial09 nizamial09 requested review from bk201, Exotelis and prokopto-dev and removed request for a team January 18, 2021 08:36
@nizamial09 nizamial09 requested review from epuertat and removed request for bk201, Exotelis and prokopto-dev January 18, 2021 08:37
@nizamial09 nizamial09 changed the title [AFTER #38938] [WIP] mgr/dashboard: Splitting tenant$user when creating rgw user mgr/dashboard: Splitting tenant$user when creating rgw user Jan 25, 2021
@nizamial09 nizamial09 removed the DNM label Jan 28, 2021
@alfonsomthd alfonsomthd added the skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology label Jan 29, 2021
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally & it LGTM! Just one thing I wanted to point out for the current functionality that shouldn't we just have Username field enabled & as required field instead?(removing user_id as required field and user can still click generate icon if both tenant & user_id are specified). So that the previous functionality of specifying username as tenant$user_id still remains.
Any thoughts on this @epuertat @alfonsomthd @votdev @s0nea ?

Dashboard automation moved this from In progress to Reviewer approved Feb 1, 2021
@epuertat epuertat moved this from Reviewer approved to Review in progress in Dashboard Feb 9, 2021
@nizamial09 nizamial09 force-pushed the tenant-user branch 2 times, most recently from 1b1bc5b to d69ca41 Compare February 17, 2021 07:55
@nizamial09
Copy link
Member Author

jenkins test make check

Copy link
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 thanks @nizamial09 !

Dashboard automation moved this from Review in progress to Reviewer approved Feb 19, 2021
@epuertat
Copy link
Member

.............................................................................
  � RgwUserFormComponent � username validation � should validate that username is required

    Control 'uid' could not be found!

      26 |     const control = this._get(controlName);
      27 |     if (!control) {
    > 28 |       throw new Error(`Control '${controlName}' could not be found!`);
         |             ^
      29 |     }
      30 |     return control;
      31 |   }

      at CdFormGroup.get (src/app/shared/forms/cd-form-group.ts:28:13)
      at FormHelper.getControl (src/testing/unit-test-helper.ts:158:24)
      at FormHelper.setValue (src/testing/unit-test-helper.ts:148:20)
      at FormHelper.expectErrorChange (src/testing/unit-test-helper.ts:187:27)
      at src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.spec.ts:159:18
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:386:30)
      at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/dist/proxy.js:117:43)
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:385:36)
      at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/dist/zone.js:143:47)

  � RgwUserFormComponent � username validation � should validate that username is valid

    Control 'uid' could not be found!

      26 |     const control = this._get(controlName);
      27 |     if (!control) {
    > 28 |       throw new Error(`Control '${controlName}' could not be found!`);
         |             ^
      29 |     }
      30 |     return control;
      31 |   }

      at CdFormGroup.get (src/app/shared/forms/cd-form-group.ts:28:13)
      at FormHelper.getControl (src/testing/unit-test-helper.ts:158:24)
      at FormHelper.setValue (src/testing/unit-test-helper.ts:148:20)
      at src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.spec.ts:164:18
      at node_modules/zone.js/dist/fake-async-test.js:610:34
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:386:30)
      at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/dist/proxy.js:117:43)
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:385:36)
      at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/dist/zone.js:143:47)

  � RgwUserFormComponent � username validation � should validate that username is invalid

    Control 'uid' could not be found!

      26 |     const control = this._get(controlName);
      27 |     if (!control) {
    > 28 |       throw new Error(`Control '${controlName}' could not be found!`);
         |             ^
      29 |     }
      30 |     return control;
      31 |   }

      at CdFormGroup.get (src/app/shared/forms/cd-form-group.ts:28:13)
      at FormHelper.getControl (src/testing/unit-test-helper.ts:158:24)
      at FormHelper.setValue (src/testing/unit-test-helper.ts:148:20)
      at src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.spec.ts:171:18
      at node_modules/zone.js/dist/fake-async-test.js:610:34
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:386:30)
      at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/dist/proxy.js:117:43)
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:385:36)
      at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/dist/zone.js:143:47)

  � RgwUserFormComponent � RgwUserCapabilities � capability button disabled when all capabilities are added

    Control 'uid' could not be found!

      26 |     const control = this._get(controlName);
      27 |     if (!control) {
    > 28 |       throw new Error(`Control '${controlName}' could not be found!`);
         |             ^
      29 |     }
      30 |     return control;
      31 |   }

      at CdFormGroup.get (src/app/shared/forms/cd-form-group.ts:28:13)
      at CdFormGroup.getValue (src/app/shared/forms/cd-form-group.ts:52:17)
      at RgwUserFormComponent.setCapability (src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.ts:404:31)
      at src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.spec.ts:320:19
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:386:30)
      at ProxyZoneSpec.Object.<anonymous>.ProxyZoneSpec.onInvoke (node_modules/zone.js/dist/proxy.js:117:43)
      at ZoneDelegate.Object.<anonymous>.ZoneDelegate.invoke (node_modules/zone.js/dist/zone.js:385:36)
      at Zone.Object.<anonymous>.Zone.run (node_modules/zone.js/dist/zone.js:143:47)

@nizamial09 nizamial09 force-pushed the tenant-user branch 2 times, most recently from e564e78 to 3f27ef5 Compare February 22, 2021 12:25
@nizamial09
Copy link
Member Author

jenkins test make check

@nizamial09
Copy link
Member Author

jenkins test api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard feature needs-review pybind skip-teuthology For PRs whose changes do not have an effect on QA runs/changes are not being tested in Teuthology
Projects
Archived in project
Dashboard
  
Done
4 participants