octopus: mgr/dashboard: Splitting tenant$user when creating rgw user #40297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: https://tracker.ceph.com/issues/47378 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit 7f4387d) Conflicts: src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-details/rgw-user-details.component.html - Accepted the current changes and pasted the new change src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-form/rgw-user-form.component.ts - Accepted incoming change and changed const modalRef = this.ModalService.show(RgwUserSubuserModalComponent); to const modalRef = this.bsModalService.show(RgwUserSubuserModalComponent); - Made some modification in getUID() function to adapt with octopus src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-user-list/rgw-user-list.component.ts - Accepted the current change and pasted the new change. Changed the $localize to this.i18n to match the octopus way
avanthakkar
added
the
skip-teuthology
avanthakkar
approved these changes
Mar 22, 2021
epuertat
approved these changes
Mar 23, 2021
alfonsomthd
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/49545
backport of #38940
parent tracker: https://tracker.ceph.com/issues/47378