cephadm: remove redundant ERROR during check-host
#38995
Conversation
| get_hostname(), args.expect_hostname)) | ||
| logger.info('Hostname "%s" matches what is expected.', | ||
| args.expect_hostname) | ||
|
|
||
| if errors: | ||
| raise Error('\n'.join(errors)) | ||
| raise Error('\nERROR: '.join(errors)) |
There was a problem hiding this comment.
I see ok the output produced ( I do not see the effect pointed by @sebastian-philipp )
Just improve little bit using plural or singular if it is needed:
If errors:
error_message_header = "Errors:\n" if len(errors)> 1 else "Error:\n"
raise Error(f'{error_message_header.join(errors)})There was a problem hiding this comment.
I think that will still cause issues for the mgr/cephadm logic @sebastian-philipp referenced:
ceph/src/pybind/mgr/cephadm/module.py
Line 1192 in beb00bd
There was a problem hiding this comment.
mmm.. I see.. with this change in place.. What if we remove that line?
|
this is a follow-up to #38667 |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
mgfritch
force-pushed
the
cephadm-check-host-errors
branch
from
7f75a74
to
4fcc91d
Compare
mgfritch
force-pushed
the
cephadm-check-host-errors
branch
from
4fcc91d
to
7419aeb
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
lgtm. |
``` ERROR: ERROR: No time synchronization is active ``` Signed-off-by: Michael Fritch <mfritch@suse.com>
mgfritch
force-pushed
the
cephadm-check-host-errors
branch
from
7419aeb
to
ace5d41
Compare
|
ping @jmolmo ? |
Signed-off-by: Michael Fritch mfritch@suse.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox