New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/cephadm: improving logging to send errors to stderr #45685
Conversation
I see, thanks for mentioning them. Before implementing my PR I have already read one of the PRs you referenced (#37712) so I was aware of the issues related with JSON output. My PR fixes are meant to fix the case of bootstrap without impacting the normal cephadm behavior (at least that's the intention behind the changes). |
jenkins test api |
1 similar comment
jenkins test api |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely completes the ask laid out in the tracker. One open question
cc6e34d
to
ffe6ae5
Compare
Fixes: https://tracker.ceph.com/issues/47905 Signed-off-by: Redouane Kachach <rkachach@redhat.com>
ffe6ae5
to
7f09307
Compare
jenkins test api |
2 failures:
|
Adding logic to use a special logging configuration during bootstrap operation. Basically in this case we will use
a normal behavior:
During all other operations (when cephadm is called from the mgr) we will continue using the current configuration:
This way we don't break the current/default functionality and we improve the logging during the bootstrap operation following a normal behavior to handle debug/error messages that any Linux/Unix user may expect.
Fixes: https://tracker.ceph.com/issues/47905
Signed-off-by: Redouane Kachach rkachach@redhat.com
Related PRs:
#41216
#37712
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows