octopus: common/ipaddr: Allow binding on lo #39343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commmit 5cf0fa8, solves the issue that the osd can't restart after seting a virtual local loopback IP. However, this commit also prevents a bgp-to-the-host over unumbered Ipv6 local-link is setup, where OSD typically are bound to the lo interface. To solve this, this single char patch simply checks against "lo:" to match only virtual interfaces instead of anything that starts with "lo". Fixes: https://tracker.ceph.com/issues/48893 Signed-off-by: Thomas Goirand <zigo@debian.org> (cherry picked from commit 201b592)
tchaikov
approved these changes
Feb 8, 2021
neha-ojha
approved these changes
Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/48904
backport of #38925
parent tracker: https://tracker.ceph.com/issues/48893
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh