Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: added missing documentation on "pubsub" in rgw_enable_apis #39382

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

gauravsitlani
Copy link
Member

@gauravsitlani gauravsitlani commented Feb 9, 2021

Fixes: https://tracker.ceph.com/issues/49203

Adding support for the term "notifications" in rgw_enable_apis

Signed-off-by: Gaurav Sitlani gauravsitlani@riseup.net

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@yuvalif
Copy link
Contributor

yuvalif commented Feb 10, 2021

jenkins test make check

@yuvalif
Copy link
Contributor

yuvalif commented Feb 11, 2021

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

Doc render available at https://ceph--39382.org.readthedocs.build/en/39382/

@yuvalif yuvalif requested a review from cbodley February 11, 2021 17:24
doc/radosgw/config-ref.rst Outdated Show resolved Hide resolved
@gauravsitlani
Copy link
Member Author

gauravsitlani commented Feb 12, 2021

@yuvalif @cbodley I added the suggested changes and squashed the commits into one. Does it look good ?

@yuvalif
Copy link
Contributor

yuvalif commented Feb 14, 2021

@yuvalif @cbodley I added the suggested changes and squashed the commits into one. Does it look good ?

LGTM

Fixes: https://tracker.ceph.com/issues/49203

Adding support for the term "notifications" in rgw_enable_apis

Signed-off-by: Gaurav Sitlani <gauravsitlani@riseup.net>
@cbodley cbodley added needs-qa and removed common labels Feb 16, 2021
@tchaikov tchaikov changed the title doc: added missing documentation on "pubsub" in rgw_enable_apis rgw: added missing documentation on "pubsub" in rgw_enable_apis Feb 26, 2021
@cbodley cbodley merged commit 38bb60b into ceph:master Mar 3, 2021
@yuvalif
Copy link
Contributor

yuvalif commented Mar 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants