cephadm: fix port_in_use when IPv6 is disabled

[p-se]

Do not return "port is in use" when the protocol family tested is not
supported (due to being deactivated).

Differentiates between

OSError: [Errno 97] Address family not supported by protocol

and

OSError: [Errno 98] Address already in use

Signed-off-by: Patrick Seidensal pseidensal@suse.com

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[github-actions]

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

[sebastian-philipp]

lgrm, but unrelated whitespace changes

[adk3798]

LGTM

[p-se]

jenkins retest this please

[p-se]

jenkins test make check

[p-se]

Building remotely on irvingi03

tests/test_cephadm.py:529: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
cephadm:6554: in port_active
    return port_in_use(self.ctx, self.port)
cephadm:966: in port_in_use
    (socket.AF_INET6, '::')
cephadm:964: in <genexpr>
    return any(_port_in_use(af, address) for af, address in (
cephadm:961: in _port_in_use
    raise e
cephadm:954: in _port_in_use
    attempt_bind(ctx, s, address, port_num)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

ctx = <cephadm.CephadmContext object at 0x7f14bb673dd8>
s = <socket.socket [closed] fd=-1, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0>
address = '0.0.0.0', port = 9443

    def attempt_bind(ctx, s, address, port):
        # type: (CephadmContext, socket.socket, str, int) -> None
        try:
            s.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
            s.bind((address, port))
        except (socket.error, OSError) as e:  # py2 and py3
            msg = 'Cannot bind to IP %s port %d: %s' % (address, port, e)
            logger.warning(msg)
            if e.errno == errno.EADDRINUSE:
>               raise OSError(msg)
E               OSError: Cannot bind to IP 0.0.0.0 port 9443: [Errno 98] Address already in use

cephadm:938: OSError

However, running the tests locally seems to work:

user@home ~/src/ceph/src/pybind/mgr ±wip-pse-cephadm-port-in-use » ../../script/run_tox.sh mgr -- cephadm | tail 
flake8 installed: DEPRECATION: --find-links option in pip freeze is deprecated. pip 21.2 will remove support for this functionality. You can find discussion regarding this at https://github.com/pypa/pip/issues/9069.,-f /home/user/src/ceph/src/pybind/mgr/wheelhouse,flake8==3.8.4,mccabe==0.6.1,pycodestyle==2.6.0,pyflakes==2.2.0
flake8 run-test-pre: PYTHONHASHSEED='3595092527'
flake8 run-test: commands[0] | flake8 --config=tox.ini cephadm cephadm
___________________________________ summary ____________________________________
  py3: commands succeeded
  mypy: commands succeeded
  test: commands succeeded
  fix: commands succeeded
  flake8: commands succeeded
  congratulations :)
user@home ~/src/ceph/src/pybind/mgr ±wip-pse-cephadm-port-in-use » 

[p-se]

jenkins test make check

[sebastian-philipp]

Building remotely on irvingi03

I think we need to mock socket.bind. Maybe

@mock.patch("socket.bind")
    def test_port_active(self, _, exporter):
        assert exporter.port_active == True

[p-se]

Building remotely on irvingi03

I think we need to mock socket.bind. Maybe

@mock.patch("socket.bind")
    def test_port_active(self, _, exporter):
        assert exporter.port_active == True

What I haven't understood yet is why this test, all of a sudden, starts making problems and hasn't done so before. I wonder if that's due to the machine or the test (maybe being canceled at the wrong moment?). But in any case, adapting the test should get us going.

[sebastian-philipp]

Building remotely on irvingi03

I think we need to mock socket.bind. Maybe

@mock.patch("socket.bind")
    def test_port_active(self, _, exporter):
        assert exporter.port_active == True

What I haven't understood yet is why this test, all of a sudden, starts making problems and hasn't done so before. I wonder if that's due to the machine or the test (maybe being canceled at the wrong moment?). But in any case, adapting the test should get us going.

cause we are no longer hiding those exceptions from the caller. which is a good thing, but now some tests did call that function and are now throwing errors.

[p-se]

Building remotely on irvingi03

I think we need to mock socket.bind. Maybe

@mock.patch("socket.bind")
    def test_port_active(self, _, exporter):
        assert exporter.port_active == True

What I haven't understood yet is why this test, all of a sudden, starts making problems and hasn't done so before. I wonder if that's due to the machine or the test (maybe being canceled at the wrong moment?). But in any case, adapting the test should get us going.

cause we are no longer hiding those exceptions from the caller. which is a good thing, but now some tests did call that function and are now throwing errors.

Turns out the code was faulty. Fixed it and created some tests to ensure it works as expected.

[sebastian-philipp]

p-se requested a review from sebastian-philipp 1 hour ago

I'm waiting for https://pulpito.ceph.com/swagner-2021-02-22_13:54:50-rados:cephadm-wip-swagner4-testing-2021-02-22-1119-distro-basic-smithi/ to be scheduled.

[sebastian-philipp]

https://pulpito.ceph.com/swagner-2021-02-22_13:54:50-rados:cephadm-wip-swagner4-testing-2021-02-22-1119-distro-basic-smithi/

[smithfarm]

NOTE: this was backported to octopus via #41602