Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pacific: Add DoutPrefixProvider for RGW Log Messages in Pacfic #40054

Merged
merged 1 commit into from
May 10, 2021
Merged

Pacific: Add DoutPrefixProvider for RGW Log Messages in Pacfic #40054

merged 1 commit into from
May 10, 2021

Conversation

alimaredia
Copy link
Contributor

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added this to the pacific milestone Mar 12, 2021
@alimaredia alimaredia changed the title Wip rgw dpp pacific Add DoutPrefixProvider for RGW Log Messages in Pacfic Mar 13, 2021
@alimaredia alimaredia changed the title Add DoutPrefixProvider for RGW Log Messages in Pacfic Pacific: Add DoutPrefixProvider for RGW Log Messages in Pacfic Mar 13, 2021
@alimaredia alimaredia mentioned this pull request Mar 13, 2021
Closed
3 tasks
@cbodley
Copy link
Contributor

cbodley commented Mar 22, 2021

has this stuff merged to master yet? none of the commit messages have cherry-picked from commit

@cbodley cbodley added the DNM label Mar 22, 2021
@alimaredia
Copy link
Contributor Author

@cbodley Nope not yet. So what I noticed is that none of the dpp commits Kalpesh or I worked on are in Pacific, so the 1 commit for this PR doesn't just include new work in #40012 but also previous commits. Also there was a fair amount of changes I had to make based on how the code bases have diverged.

Should this final commit still say "cherry-picked from" with all of the commits it's based off of?

@tchaikov
Copy link
Contributor

jenkins test make check

@alimaredia alimaredia force-pushed the wip-rgw-dpp-pacific branch 2 times, most recently from e397775 to 348ca85 Compare March 30, 2021 03:59
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@alimaredia alimaredia requested review from a team as code owners April 14, 2021 12:58
@alimaredia alimaredia requested review from pereman2 and Waadkh7 and removed request for a team April 14, 2021 12:58
@github-actions
Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@idryomov idryomov changed the base branch from pacific to pacific-saved April 20, 2021 15:16
@idryomov idryomov changed the base branch from pacific-saved to pacific April 20, 2021 15:16
@alimaredia alimaredia requested review from cbodley and removed request for a team, pereman2 and Waadkh7 April 29, 2021 15:54
@alimaredia
Copy link
Contributor Author

Her is a clean run on teuthology: https://pulpito.ceph.com/amaredia-2021-04-29_01:24:51-rgw-wip-rgw-dpp-pacific-distro-basic-smithi/

@alimaredia
rgw: add DPP's to logging for most ops
338a233 
This commit contains the following major
changes:

- Most log output lines for major ops now have
DoutPrefixProviders.

- Create new macro ldpp_subdout. This macro is meant
as a replacement for lsubdout for headerfiles that
do not define the rgw subsys.

- Changes to RGWObjManifest begin and end iterators.

- Make it so that rgw_dencoder.cc should only contain the
logic related to encoding.

Also add dpp to ldouts and lderr's already using
req_state and replace sync_env/env->dpp's with dpp's

Signed-off-by: Ali Maredia <amaredia@redhat.com>
Signed-off-by: Kalpesh Pandya <kapandya@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 6cfc2ce)
@alimaredia
Copy link
Contributor Author

Clean teuthology run here: https://pulpito.ceph.com/amaredia-2021-05-06_20:11:28-rgw-wip-rgw-dpp-pacific-distro-basic-smithi/

@cbodley cbodley removed the DNM label May 10, 2021
@cbodley cbodley merged commit d217ead into ceph:pacific May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees
No one assigned
Labels
common rgw tests
Projects
None yet
Milestone
pacific
Development

Successfully merging this pull request may close these issues.
3 participants
@alimaredia @cbodley @tchaikov