install-deps.sh: install libpmem libraries if WITH_PMEM is set #40617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
batrick
approved these changes
Apr 6, 2021
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-system-pmem
branch
from
cec093a
to
a5ec9c8
Compare
so we can at least build-test the rwl cache plugin in "make check" run. this is an opt-in option which is only enabled if WITH_PMEM is "true", we will set it in the corresponding ceph-build job. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-system-pmem
branch
from
a5ec9c8
to
69a7ed4
Compare
|
tested using WITH_PMEM=true ./run-make-check.shon a focal machine. @batrick thanks for your review. i just realized that i forgot to update @trociny @CongMinYin @cyx1231st hi folks, as Jason pointed out we need to have the pmem cache support by default. but pmem v1.10 is not packaged by ubuntu focal. so i compiled and uploaded the latest libpmem packages and its dependencies to chacra, so we can at least build-test it in "make check". |
batrick
approved these changes
Apr 8, 2021
|
This is still somehow creating mangled Do we need to install a special version built and hosted by us in shaman or is the distro-provided version okay? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox