Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Include Network address and labels on Host Creation form #41123

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented May 3, 2021

The ability to create host by specifying network address and also create
labels.

host-create

https://tracker.ceph.com/issues/50318
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@avanthakkar
Copy link
Contributor

I see some py file changes here, so can you also add integration/unit-testing for backend? Thanks already!

@avanthakkar
Copy link
Contributor

avanthakkar commented May 3, 2021

Just to bring in some discussion about API versioning (not related to this PR)
I'm wondering as we are changing some endpoints for e.g. here it's create host endpoint which now provides some additional parameters and also previously I've seen in some PRs changing the endpoint "definition" , so shall we consider the point of introducing versioning for these updated endpoints/updating API versioning? @epuertat @alfonsomthd Thoughts!?

Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think e2e tests are required here too. As now you can create host with not just hostname but there are some additional parameters which I think should be tested in e2e too.
For e.g create host, here hostname is the only argument, it should be tested with additional parametres introduced here.

@nizamial09
Copy link
Member Author

@avanthakkar Included some unit testing in backend.

@nizamial09 nizamial09 requested a review from pereman2 May 18, 2021 06:53
@epuertat epuertat added the DNM label May 19, 2021
@nizamial09 nizamial09 changed the title mgr/dashboard: Include Network address and labels on Host Creation form [AFTER #41395] mgr/dashboard: Include Network address and labels on Host Creation form May 19, 2021
@avanthakkar avanthakkar changed the title [AFTER #41395] mgr/dashboard: Include Network address and labels on Host Creation form mgr/dashboard: Include Network address and labels on Host Creation form Jun 4, 2021
The ability to create host by specifying network address and also create
labels.

https://tracker.ceph.com/issues/50318
Signed-off-by: Nizamudeen A <nia@redhat.com>
@github-actions github-actions bot added the tests label Jun 7, 2021
@avanthakkar avanthakkar removed the DNM label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants