-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mgr/dashboard: Include Network address and labels on Host Creation form #41123
Conversation
I see some py file changes here, so can you also add integration/unit-testing for backend? Thanks already! |
Just to bring in some discussion about API versioning (not related to this PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think e2e tests are required here too. As now you can create host with not just hostname
but there are some additional parameters which I think should be tested in e2e too.
For e.g create host, here hostname
is the only argument, it should be tested with additional parametres introduced here.
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/host-form/host-form.component.html
Outdated
Show resolved
Hide resolved
f4db0f0
to
fe53699
Compare
@avanthakkar Included some unit testing in backend. |
fe53699
to
d592a02
Compare
d592a02
to
040f541
Compare
040f541
to
0d175ab
Compare
The ability to create host by specifying network address and also create labels. https://tracker.ceph.com/issues/50318 Signed-off-by: Nizamudeen A <nia@redhat.com>
0d175ab
to
7c1df69
Compare
The ability to create host by specifying network address and also create
labels.
https://tracker.ceph.com/issues/50318
Signed-off-by: Nizamudeen A nia@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox