behave_tests: Implemented basic behave test scenario's for cephadm, ceph shell and OSD commands

[SudhanAruna]

This commit includes the basic implementation of behave test scenario's ( for cephadm, ceph shell and OSD commands) and
python implementations for interacting with kcli and behave test cases. The test scenarios can be execute all together or only the
specific scenarios with tags.

Checklist

• References tracker ticket
• Updates documentation if necessary
• Includes tests for new functionality or reproducer for bug

---

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox

[jmolmo]

Great beginning!

First thing to improve: We need a Tox environment.

Tox allow us to use virtual environments to install dependencies and execute our python scripts without need to install these dependencies in any host that execute our scripts. We can start with a basic tox.ini file placed in the like:

[jolmomar@juanmipc behave_tests]$ cat tox.ini
[tox]
envlist = py36, flake8
skipsdist = true

[testenv]
deps =
   behave
   jinja2
commands = behave

[testenv:flake8]
deps=
   pep8-naming
   flake8
commands=flake8 {posargs:features}

After that you can execute our behave test just typing:

# tox -e py36

and you can reiew your python style problems with:

# tox -e flake8

Note: Obviously, tox must be installed in your laptop

[jmolmo]

Please fix the small problem rendering the disk section.

[tchaikov]

if the test based on the behave framework falls into the category of "test", i'd suggest move it to src/test.

dismissed.

[tchaikov]

@SudhanAruna i am not qualified to review this change. i'd defer this to cephadm experts like @jmolmo and @sebastian-philipp .

[jmolmo]

Very good progress!!! This starts to seem something really awesome. Good job Arun!!

Apart of the minor suggestions i did..is time to start with a next kind of feature:
Feature: Execute commands using the ceph shell

very similar to what we have in the current feature, but now the commands and the result comes from "cephadm shell"

[jmolmo]

We need to improve this part.. because waiting for nothing is not the right thing to do :-)

What we really need is to execute something and if the expected output is not the desired, wait a little bit, and execute again the command to see if the things have changed.

When can add the decorator in all the functions that must obtain a result a the result maybe is not going to be immediate, the definition of this step could be very similar to the one proposed by you_

@then("I will continue trying to get and compare the result every {wait_time:n} seconds with a timeout of {timeout_time:n} seconds ")

I suggest to create a function to work as decorator. This function will receive as parameter the function that implements the step and returns true if the function success , and false if the parameter function has failed 8 or the timeout expires.
We will need also to change functions to implement each step to return a boolean.

Ex:

@execute_with_timeout(60,5)
def execute_step(context):
     ... 
    return expected_output == executed_output)

def execute_with_timeout(f, timeout, wait)
time_waiting =0
while timeout > time_waiting:
result = f()
if result:
return result
else:
time.sleep(wait)
time_waiting += wait
print("Timeout reached waiting for expected output")
return result

[alfonsomthd]

@SudhanAruna Can you please update the PR description on how to test this?

[SudhanAruna]

@SudhanAruna Can you please update the PR description on how to test this?

@alfonsomthd
I have included how to run the test with behave in the README.md file. Should I update the PR descriptions also?

[alfonsomthd]

@SudhanAruna Can you please update the PR description on how to test this?

@alfonsomthd
I have included how to run the test with behave in the README.md file. Should I update the PR descriptions also?

@SudhanAruna The README is OK but you should add in the PR description (as well as in the commit body):
Fixes: <cep-tracker-issue-url>

[SudhanAruna]

@SudhanAruna Can you please update the PR description on how to test this?

@alfonsomthd
I have included how to run the test with behave in the README.md file. Should I update the PR descriptions also?

@SudhanAruna The README is OK but you should add in the PR description (as well as in the commit body):
Fixes: <cep-tracker-issue-url>

@alfonsomthd I have updated the PR as requested but I couldn't find the ceph tacker issue for this project.

[jmolmo]

jenkins retest this please