qa: use kclient xattr to lookup client id #42081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxbsz
reviewed
Jun 29, 2021
jtlayton
reviewed
Jun 29, 2021
qa/tasks/cephfs/kernel_mount.py
Outdated
| @@ -202,18 +180,54 @@ def read_debug_file(self, filename): | |||
| return None | |||
| raise | |||
|
|
|||
| def _get_global_id(self): | |||
| try: | |||
| p = self.run_shell_payload(f"getfattr --only-values -n ceph.client_id .", stdout=StringIO()) | |||
There was a problem hiding this comment.
Can you not call getxattr() directly from python? I'd think that would be possible, and it would be more efficient.
There was a problem hiding this comment.
You're probably thinking of the python programs that call getxattr for us. Those are transmitted to the "client" host and then executed. It would probably be less efficient than calling /bin/getfattr.
|
https://pulpito.ceph.com/pdonnell-2021-06-29_14:48:22-fs-master-distro-basic-smithi/ will test more widely in a future qa run |
|
jenkins test make check |
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 29, 2021
* refs/pull/42081/head: qa: use kclient xattr to lookup client id qa: refactor reading debug file code qa: get mount id before failing fs
Otherwise getxattr will hang. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
No need to invoke Python to read a file! Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jun 30, 2021
* refs/pull/42081/head: qa: use kclient xattr to lookup client id qa: refactor reading debug file code qa: get mount id before failing fs
batrick
added a commit
to batrick/ceph
that referenced
this pull request
Jul 2, 2021
* refs/pull/42081/head: qa: use kclient xattr to lookup client id qa: refactor reading debug file code qa: get mount id before failing fs
Added relatively recently but in RHEL 8.4. Fixes: https://tracker.ceph.com/issues/51183 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
https://tracker.ceph.com/projects/cephfs/wiki/Master#2021-July-01 with small follow-on fix in test branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.