Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include/filepath: do not exceed the path depth #42215

Closed
wants to merge 1 commit into from
Closed

include/filepath: do not exceed the path depth #42215

wants to merge 1 commit into from

Conversation

jhonxue
Copy link
Contributor

@jhonxue jhonxue commented Jul 7, 2021 •
edited
Loading

In prefixpath function, do not exceed the path depth
Fixes: https://tracker.ceph.com/issues/51586

Signed-off-by: Xue Yantao xueyantao2114@163.com

Checklist

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the cephfs Ceph File System label Jul 7, 2021
batrick
batrick requested changes Jul 7, 2021
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain what the commit is fixing in the commit message:

https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#commit-message

Also, the tracker ticket needs updated to explain the issue.

@jhonxue jhonxue changed the title include/filepath: fix prefixpath include/filepath: do not exceed the path depth Jul 8, 2021
@jhonxue jhonxue requested a review from batrick July 8, 2021 03:40
@jhonxue
Copy link
Contributor Author

jhonxue commented Jul 8, 2021

Please explain what the commit is fixing in the commit message:

https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#commit-message

Also, the tracker ticket needs updated to explain the issue.

ok, i had modified it

batrick
batrick requested changes Jul 14, 2021
View reviewed changes
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no

src/include/filepath.h Show resolved Hide resolved
@jhonxue @batrick
include/filepath: In prefixpath function, do not exceed the path depth
f93a4eb 
Fixes: https://tracker.ceph.com/issues/51586

Co-authored-by: Patrick Donnelly <batrick@users.noreply.github.com>
Signed-off-by: Xue Yantao <xueyantao2114@163.com>
@batrick
Copy link
Member

batrick commented Jul 15, 2021

@jhonxue did you mean to update the change? I don't see a difference?

@stale
Copy link

stale bot commented Jan 9, 2022

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Jan 9, 2022
@djgalloway djgalloway changed the base branch from master to main July 3, 2022 00:00
@github-actions github-actions bot removed the stale label Jul 28, 2022
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Nov 28, 2022
@github-actions
Copy link

This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution!

@github-actions github-actions bot closed this Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batrick batrick batrick requested changes

Assignees
No one assigned
Labels
cephfs Ceph File System stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhonxue @batrick