pacific: src/pybind/mgr/mirroring/fs/snapshot_mirror.py: do not assume a cephf… #42226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-mirror daemon is always running We should not assume a daemon is runnning. If the daemon is not running we get the default value of None. So let's skip the status if no daemon is running yet. Fixes: https://tracker.ceph.com/issues/51476 Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit dd45ec4)
leseb
approved these changes
Jul 8, 2021
vshankar
approved these changes
Jul 12, 2021
joscollin
approved these changes
Jul 15, 2021
votdev
pushed a commit
to votdev/ceph
that referenced
this pull request
Aug 2, 2021
pacific: src/pybind/mgr/mirroring/fs/snapshot_mirror.py: do not assume a cephf… Reviewed-by: Venky Shankar <vshankar@redhat.com> Reviewed-by: Sébastien Han <seb@redhat.com> Reviewed-by: Jos Collin <jcollin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/51547
backport of #42139
parent tracker: https://tracker.ceph.com/issues/51476
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh