workunits/rgw: semicolon terminates perl statements #43168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a lexical error in one line of code added in 90e9307, removing the dependency on lsb_release, on 8/16/2021. Fixes: https://tracker.ceph.com/issues/52613 Signed-off-by: Matt Benjamin <mbenjamin@redhat.com> (cherry picked from commit 221fdb8)
|
@mattbenjamin pls close #43165 |
yuriw
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
@mattbenjamin see at the run results^, I suspect the failures were masked before this fix
let me know if you want to merge it and I will unlock the repo
|
@yuriw seems like we -must- merge this one, I'm reviewing the other failures in our downstream standup |
|
@cbodley has rulings on the outstanding test failures :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a lexical error in one line of code added in
90e9307, removing the dependency
on lsb_release, on 8/16/2021.
Fixes: https://tracker.ceph.com/issues/52613
Signed-off-by: Matt Benjamin mbenjamin@redhat.com
(cherry picked from commit 221fdb8)
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox