Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: extend daemon actions to host details #44014

Merged
merged 2 commits into from
Mar 29, 2022
Merged

mgr/dashboard: extend daemon actions to host details #44014

merged 2 commits into from
Mar 29, 2022

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Nov 18, 2021 •
edited
Loading

Currently daemon actions like start,stop,restart,redploy can be done at
Cluster->Services by selecting specific service.

But same details table used in Cluster-> Hosts daemons of specific host
User should do those actions from here as well

Also Hostname column under the details section of a host seems irrelevant since we are expanding a particular host and only the daemons of that host will be present in that section. No need to point it out again.

BEFORE
Screenshot from 2021-11-19 12-57-25

AFTER
Screenshot from 2022-03-23 12-00-47

Fixes: https://tracker.ceph.com/issues/54559
Fixes: https://tracker.ceph.com/issues/53355
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
  • Teuthology
    • Completed teuthology run
    • No teuthology test necessary (e.g., documentation)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 requested a review from a team as a code owner November 18, 2021 20:45
@nizamial09 nizamial09 requested review from alfonsomthd and avanthakkar and removed request for a team November 18, 2021 20:45
@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

1 similar comment
@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@avanthakkar
Copy link
Contributor

Ok since we already doing some cleanup for this table how abt merging daemon type & id into 1 single column...similar to what we already have in Host Services column (<daemon_type>.<daemon_id>) . Also renaming the Services column to Daemons .
I think a tracker is already linked to both of these cleanups, will try to find them.

avanthakkar
avanthakkar reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@nizamial09 nizamial09 force-pushed the host-detail-service-column branch 6 times, most recently from 3b6f916 to 50ee2cd Compare March 1, 2022 05:52
@nizamial09
Copy link
Member Author

how abt merging daemon type & id into 1 single column

@avanthakkar done!

Also renaming the Services column to Daemons

which Services column you are referring to? The tab in the host-details is already called Daemons

I think a tracker is already linked to both of these cleanups

I couldn't find one.

@nizamial09
Copy link
Member Author

jenkins retest this please

@nizamial09
mgr/dashboard: extend daemon actions to host details
c11096e 
The daemon actions are only available in the service details section but
not on the host details. This takes care of that.

Fixes: https://tracker.ceph.com/issues/54559
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 changed the title mgr/dashboard: Hide hostname column of daemon table in host details mgr/dashboard: extend daemon actions to host details Mar 23, 2022
@epuertat epuertat removed the request for review from alfonsomthd March 23, 2022 09:46
aaSharma14
aaSharma14 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Contributor

@aaSharma14 aaSharma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.!

sunilangadi2
sunilangadi2 approved these changes Mar 25, 2022
View reviewed changes
Copy link

@sunilangadi2 sunilangadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nizamial09 Changes and screenshot looks good to me.

@epuertat epuertat merged commit 729e956 into ceph:master Mar 29, 2022
@epuertat epuertat deleted the host-detail-service-column branch March 29, 2022 08:49
This was referenced Mar 31, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunilangadi2 sunilangadi2 sunilangadi2 approved these changes

@aaSharma14 aaSharma14 aaSharma14 approved these changes

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

@Sarthak0702 Sarthak0702 Awaiting requested review from Sarthak0702

@pereman2 pereman2 Awaiting requested review from pereman2

@epuertat epuertat Awaiting requested review from epuertat

Assignees
No one assigned
Labels
dashboard needs-review pybind
Projects
Ceph-Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nizamial09 @avanthakkar @sunilangadi2 @aaSharma14 @epuertat