Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd-mirror: make RemoveImmediateUpdate test synchronous #44064

Merged
merged 1 commit into from Nov 24, 2021
Merged

rbd-mirror: make RemoveImmediateUpdate test synchronous #44064

merged 1 commit into from Nov 24, 2021

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Nov 23, 2021 •
edited

Try fixing sporadic failure in RemoveImmediateUpdate by removing
asynchronous from the test.

Fixes: https://tracker.ceph.com/issues/53375
Signed-off-by: Arthur Outhenin-Chalandre arthur.outhenin-chalandre@cern.ch

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
  • Teuthology
    • Completed teuthology run
    • No teuthology test necessary (e.g., documentation)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@MrFreezeex
Copy link
Member Author

MrFreezeex commented Nov 23, 2021 •
edited

Hopefully this solves the issue... i wasn't able to reproduce it on my end so I can't say for sure :/.

@MrFreezeex
rbd-mirror: make RemoveImmediateUpdate test synchronous
9385acf 
Try fixing sporadic failure linked in the tracker in
TestMockMirrorStatusUpdater.RemoveImmediateUpdate by making it
synchronous.

Fixes: https://tracker.ceph.com/issues/53375
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
@MrFreezeex MrFreezeex changed the title rbd-mirror: make RemoveImmediateUpdate synchronous rbd-mirror: make RemoveImmediateUpdate test synchronous Nov 23, 2021
trociny
trociny approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@trociny trociny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though it would be nice to reproduce the issue somehow and make sure this is the correct fix.

@ideepika may be you will have a luck?

Just thinking, may be adding some sleep in the code may help to reproduce this...

@ideepika
Copy link
Member

LGTM though it would be nice to reproduce the issue somehow and make sure this is the correct fix.

@ideepika may be you will have a luck?

Just thinking, may be adding some sleep in the code may help to reproduce this...

will try that thanks @trociny @MrFreezeex

@ideepika
Copy link
Member

jenkins test make check

@ideepika
Copy link
Member

feel free to test with jenkins command, I see every 5-7th task failing with rbd-unit test https://jenkins.ceph.com/job/ceph-pull-requests/

@ideepika
Copy link
Member

jenkins test make check

3 similar comments
@ideepika
Copy link
Member

jenkins test make check

@ideepika
Copy link
Member

jenkins test make check

@trociny
Copy link
Contributor

trociny commented Nov 24, 2021

jenkins test make check

@trociny
Copy link
Contributor

trociny commented Nov 24, 2021

@ideepika Ah, it seems you were referring to librbd unittest hangs for TestLibRBD.ConcurentOperations, which I was able to reproduce with the last jenkins run [1].

This PR fixes a hang in rbd mirror unit tests, and is not related. We need a separate tracker ticket for TestLibRBD.ConcurentOperations failure if we don't have yet.

[1] https://jenkins.ceph.com/job/ceph-pull-requests/86178/console

@trociny
Copy link
Contributor

trociny commented Nov 24, 2021

jenkins test make check

@trociny
Copy link
Contributor

trociny commented Nov 24, 2021

In the tracker I found TestLibRBD.ConcurentOperations mentioned here [1]. Though this ticket seems to be rather a mix of non-related librbd unit test failures.

[1] https://tracker.ceph.com/issues/47596#note-3

@ideepika
Copy link
Member

jenkins test make check

@ideepika
Copy link
Member

ideepika commented Nov 24, 2021 •
edited

In the tracker I found TestLibRBD.ConcurentOperations mentioned here [1]. Though this ticket seems to be rather a mix of non-related librbd unit test failures.

[1] https://tracker.ceph.com/issues/47596#note-3

did not see this failure explictly, in any of the failing runs, no failed test, only timeout.

@ideepika
Copy link
Member

In the tracker I found TestLibRBD.ConcurentOperations mentioned here [1]. Though this ticket seems to be rather a mix of non-related librbd unit test failures.
[1] https://tracker.ceph.com/issues/47596#note-3

did not see this failure explictly, in any of the failing runs, no failed test, only timeout.

seeing this one locally: https://tracker.ceph.com/issues/43274#note-6 I agree, it's a mix bag

@trociny trociny merged commit ac2c5a9 into ceph:master Nov 24, 2021
@MrFreezeex MrFreezeex deleted the fix-statusupdater-utest branch November 24, 2021 15:55
This was referenced Nov 24, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trociny trociny trociny approved these changes

Assignees
No one assigned
Labels
rbd tests
Projects
None yet
Milestone
No milestone
3 participants
@MrFreezeex @ideepika @trociny