Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pacific: rbd-mirror: make RemoveImmediateUpdate test synchronous #44094

Merged
merged 1 commit into from Feb 21, 2022

Conversation

MrFreezeex
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/53386


backport of #44064
parent tracker: https://tracker.ceph.com/issues/53375

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

Try fixing sporadic failure linked in the tracker in
TestMockMirrorStatusUpdater.RemoveImmediateUpdate by making it
synchronous.

Fixes: https://tracker.ceph.com/issues/53375
Signed-off-by: Arthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
(cherry picked from commit 9385acf)
@github-actions github-actions bot added this to the pacific milestone Nov 24, 2021
@MrFreezeex
Copy link
Member Author

unrelated pip failure https://jenkins.ceph.com/job/ceph-pull-requests/86224/:

ERROR: Exception:
Traceback (most recent call last):
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/cli/base_command.py", line 164, in exc_logging_wrapper
    status = run_func(*args)
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/cli/req_command.py", line 205, in wrapper
    return func(self, options, args)
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/commands/install.py", line 360, in run
    _, build_failures = build(
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/wheel_builder.py", line 346, in build
    wheel_file = _build_one(
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/wheel_builder.py", line 227, in _build_one
    _verify_one(req, wheel_path)
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/wheel_builder.py", line 174, in _verify_one
    dist = get_wheel_distribution(FilesystemWheel(wheel_path), canonical_name)
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/metadata/__init__.py", line 51, in get_wheel_distribution
    return Distribution.from_wheel(wheel, canonical_name)
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/metadata/pkg_resources.py", line 37, in from_wheel
    with wheel.as_zipfile() as zf:
  File "/home/jenkins-build/build/workspace/ceph-pull-requests/build/mgr-dashboard-check-virtualenv/lib/python3.8/site-packages/pip/_internal/metadata/base.py", line 321, in as_zipfile
    return zipfile.ZipFile(self.location, allowZip64=True)
  File "/usr/lib/python3.8/zipfile.py", line 1269, in __init__
    self._RealGetContents()
  File "/usr/lib/python3.8/zipfile.py", line 1336, in _RealGetContents
    raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

@MrFreezeex
Copy link
Member Author

jenkins test make check

@idryomov
Copy link
Contributor

@ideepika This is labeled with wip-deepika3-testing and wip-deepika2-testing, what were the results?

@ideepika
Copy link
Member

@idryomov https://pulpito.ceph.com/ideepika-2021-12-09_11:27:25-rbd-wip-deepika2-testing-pacific-distro-default-smithi/ this is the branch I used for testing containing changes from this branch; doesn't look suspicious, don't remember why I missed it.

But probably I can run another round of tests on it

@ideepika ideepika merged commit db4c2e2 into ceph:pacific Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants