mgr/cephadm: fix 'cephadm osd activate' on existing osd devices #44228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
cephadm-fix-osd-activate
branch
from
6c3b469
to
a1fedfe
Compare
liewegas
changed the title
sebastian-philipp
approved these changes
Dec 9, 2021
sebastian-philipp
approved these changes
Dec 15, 2021
|
jenkins test api |
When this code was introduced way back in ea987a0, for some reason I was focused only on freshly created OSDs. The get_osd_uuid_map() helper is used by deploy_osd_daemons_for_existing_osds() which is called not only by OSD creation but also by 'ceph cephadm osd activate', which is meant to instantiate daemons for existing OSD devices (e.g., devices that were reattached to a new server, or whose /var/lib/ceph/$fsid/osd.$id directory was lost for some other reason. However, if we ignore OSDs with up_from > 0, then we can't recreate a daemon instance for such existing OSDs--arguably the most important ones, since they may hold real data. Fixes: https://tracker.ceph.com/issues/53491 Signed-off-by: Sage Weil <sage@newdream.net>
If we are trying to deploy new or newly-found osds, we can skip the ones that already have cephadm daemons deployed. Fixes: https://tracker.ceph.com/issues/53491 Signed-off-by: Sage Weil <sage@newdream.net>
liewegas
force-pushed
the
cephadm-fix-osd-activate
branch
from
d2925dd
to
684926b
Compare
liewegas
force-pushed
the
cephadm-fix-osd-activate
branch
4 times, most recently
from
a48e76a
to
4acdfb1
Compare
Make sure this command behaves when the /var/lib/ceph osd.NNN dir is removed. Signed-off-by: Sage Weil <sage@newdream.net>
liewegas
force-pushed
the
cephadm-fix-osd-activate
branch
from
4acdfb1
to
867bf04
Compare
adk3798
added a commit
to adk3798/ceph
that referenced
this pull request
Jun 6, 2022
As is already done when checking the lvm list results and should also be done for checking raw list but is missing do ot a backporting mistake Tachnically a partial backport of ceph#44228 that was not included in ceph#44627 because raw osd support was not in pacific then Signed-off-by: Adam King <adking@redhat.com>
14 tasks
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Jun 23, 2022
As is already done when checking the lvm list results and should also be done for checking raw list but is missing do ot a backporting mistake Tachnically a partial backport of ceph#44228 that was not included in ceph#44627 because raw osd support was not in pacific then Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 9f4800a) Resolves: rhbz#2094112 Resolves: rhbz#2093788
mkogan1
pushed a commit
to mkogan1/ceph
that referenced
this pull request
Aug 7, 2022
As is already done when checking the lvm list results and should also be done for checking raw list but is missing do ot a backporting mistake Tachnically a partial backport of ceph#44228 that was not included in ceph#44627 because raw osd support was not in pacific then Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 9f4800a) Resolves: rhbz#2094112 Resolves: rhbz#2093788
NitzanMordhai
pushed a commit
to NitzanMordhai/ceph
that referenced
this pull request
Nov 19, 2023
As is already done when checking the lvm list results and should also be done for checking raw list but is missing do ot a backporting mistake Tachnically a partial backport of ceph#44228 that was not included in ceph#44627 because raw osd support was not in pacific then Signed-off-by: Adam King <adking@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox