Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: rgwlc: remove lc entry on bucket delete #44729

Merged
merged 1 commit into from
Mar 22, 2022
Merged

pacific: rgwlc: remove lc entry on bucket delete #44729

merged 1 commit into from
Mar 22, 2022

Conversation

cfsnyder
Copy link
Contributor

backport tracker: https://tracker.ceph.com/issues/53849

backport of #36308
parent tracker: https://tracker.ceph.com/issues/46728

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@cfsnyder cfsnyder added this to the pacific milestone Jan 21, 2022
@yuriw
Copy link
Contributor

yuriw commented Feb 23, 2022

@cfsnyder suspect this PR breaks the build

https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=centos8,DIST=centos8,MACHINE_SIZE=gigantic/60877//consoleFull

/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.2.7-490-gdd072787/rpm/el8/BUILD/ceph-16.2.7-490-gdd072787/src/rgw/rgw_sal_rados.cc: In member function ‘virtual int rgw::sal::RGWRadosBucket::remove_bucket(const DoutPrefixProvider*, bool, bool, req_info*, optional_yield)’:
/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos8/DIST/centos8/MACHINE_SIZE/gigantic/release/16.2.7-490-gdd072787/rpm/el8/BUILD/ceph-16.2.7-490-gdd072787/src/rgw/rgw_sal_rados.cc:139:22: error: no matching function for call to ‘RGWLC::remove_bucket_config(rgw::sal::RGWRadosBucket*, rgw::sal::RGWAttrs&)’
this, get_attrs());
^

@yuriw yuriw removed the needs-qa label Feb 23, 2022
@mattbenjamin @cfsnyder
rgwlc: remove lc entry on bucket delete
aa90cbd 
Buckets with lifecycle policies installed have a state entry that
must also be deleted when the bucket is removed.

Fixes: https://tracker.ceph.com/issues/46728

N.b., should really be generic, not specific to the RADOS store, but
there doesn't seem to be a clean model for implementing generic side
effects in Zipper, currently.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit cc1e812)

Conflicts:
	src/rgw/rgw_sal_rados.cc

Cherry-pick notes:
- must pass this->info as first param to remove_bucket_config
- conflict with includes
@yuriw yuriw merged commit 71bd544 into ceph:pacific Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dang dang dang approved these changes

Assignees
No one assigned
Labels
needs-qa rgw wip-yuri3-testing
Projects
None yet
Milestone
pacific
Development

Successfully merging this pull request may close these issues.
4 participants
@cfsnyder @yuriw @dang @mattbenjamin