Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: change the readFile to readFileSync #44956

Merged
merged 1 commit into from Feb 9, 2022
Merged

mgr/dashboard: change the readFile to readFileSync #44956

merged 1 commit into from Feb 9, 2022

Conversation

nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Feb 9, 2022 •
edited

Apparently the readFile i added in #44934 is async and that's not what
we want. so changing it to the synchronous call that is readFileSync

On the Branch, we can see that the this PR is being checked against master instead of the default baselineBranch
Screenshot 2022-02-09 225638

Fixes: https://tracker.ceph.com/issues/54190
Signed-off-by: Nizamudeen A nia@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@nizamial09 nizamial09 requested a review from a team as a code owner February 9, 2022 15:38
@nizamial09 nizamial09 added this to In progress in Dashboard via automation Feb 9, 2022
@nizamial09 nizamial09 requested review from sunilangadi2 and removed request for a team February 9, 2022 15:38
@github-actions github-actions bot added the pybind label Feb 9, 2022
Dashboard automation moved this from In progress to Reviewer approved Feb 9, 2022
@epuertat epuertat added the needs-quincy-backport backport required for quincy label Feb 9, 2022
@nizamial09
mgr/dashboard: change the readFile to readFileSync
cbfdd55 
Apparently the readFile i added in ceph#44934 is async and that's not what
we want. so changing it to the synchronous call that is readFileSync

Fixes: https://tracker.ceph.com/issues/54190
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09 nizamial09 mentioned this pull request Feb 9, 2022
Merged
14 tasks
@epuertat epuertat merged commit f5b79d7 into ceph:master Feb 9, 2022
Dashboard automation moved this from Reviewer approved to Done Feb 9, 2022
@epuertat epuertat deleted the appli-fix branch February 9, 2022 19:44
@epuertat epuertat mentioned this pull request Feb 9, 2022
Merged
@epuertat epuertat removed the needs-quincy-backport backport required for quincy label Feb 9, 2022
@nizamial09 nizamial09 mentioned this pull request Feb 10, 2022
Merged
@votdev votdev mentioned this pull request Feb 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epuertat epuertat epuertat approved these changes

@sunilangadi2 sunilangadi2 Awaiting requested review from sunilangadi2 sunilangadi2 was automatically assigned from ceph/dashboard

Assignees
No one assigned
Labels
dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Dashboard
  
Done
Milestone
No milestone
2 participants
@nizamial09 @epuertat