pacific: mgr/dashboard: "Please expand your cluster first" shouldn't be shown if cluster is already meaningfully running #45044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
requested review from
sunilangadi2 and
nizamial09
and removed request for
a team
mgfritch
approved these changes
Feb 15, 2022
nizamial09
approved these changes
Feb 16, 2022
nizamial09
changed the title
|
jenkins test dashboard |
|
jenkins test dashboard cephadm |
|
@nizamial09 visualTests/dashboard.vrt-spec.ts is failing here, do we need to backport #44956 to Pacific, too? See your comment #44951 (comment) |
|
Made some changes in the applitools and its passing now. |
s0nea
approved these changes
Feb 16, 2022
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
votdev
force-pushed
the
wip-54284-pacific
branch
from
615171f
to
2cbd402
Compare
…if cluster is already meaningfully running This PR will assume that a cluster is already up and fully running. If this should not be the expected behaviour, deployment tools have to set 'INSTALLED' explicitly. Without this assumption it might happen that upgraded and fully running clusters, e.g. Octopus -> Pacific, will show the 'Expand Cluster' on first log in. cephadm will take care that the bootstrap phase will write the necessary key to show the 'Expand cluster' page. Fixes: https://tracker.ceph.com/issues/54215 Signed-off-by: Volker Theile <vtheile@suse.com> (cherry picked from commit 48fff60) Conflicts: src/cephadm/cephadm Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
wip-54284-pacific
branch
from
2cbd402
to
7a8371f
Compare
|
jenkins test dashboard |
|
jenkins test make check |
|
It seems the Pacific branch has been broken by another PR that is RBD related. |
|
jenkins test make check |
|
jenkins test dashboard |
|
@epuertat Can this be merged after all checks are successful? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/54284
backport of #44951
parent tracker: https://tracker.ceph.com/issues/54215
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh