Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

octopus: backport qemu-iotests fixup for centos stream 8 #45206

Merged

Conversation

idryomov
Copy link
Contributor

@idryomov idryomov commented Mar 1, 2022

Backport commit df96b85 ("qa/workunits/rbd: use xenial version of qemu-iotests for centos stream 8") to octopus. The octopus backport was missed because initially it wasn't intended to be backported at all -- @ktdreyer backported it to pacific in #43001 as part of a conflict resolution for a different backport.

idryomov and others added 2 commits February 28, 2022 22:54
It is already used for centos 8(.3) and rhel 8(.4).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit df96b85)
The lsb_release utility brings in a lot of other dependencies. Remove
it from the RBD workunit script.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
(cherry picked from commit 65f4d6e)
@idryomov
Copy link
Contributor Author

idryomov commented Mar 1, 2022

jenkins test make check

@yuriw
Copy link
Contributor

yuriw commented Mar 1, 2022

jenkins test make check

1 similar comment
@yuriw
Copy link
Contributor

yuriw commented Mar 1, 2022

jenkins test make check

@idryomov
Copy link
Contributor Author

idryomov commented Mar 2, 2022

The build fails due to stupid issues in the SPDK submodule:

== Build buildtools/pmdinfogen
  HOSTCC pmdinfogen.o
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.c:20:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.c: In function 'parse_elf':
/home/jenkins-build/build/workspace/ceph-pull-requests/src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.h:83:1: error: this 'else' clause does not guard... [-Werror=misleading-indentation]

This is an unrelated test-only change so I'm going to ignore the build failure.

@idryomov idryomov merged commit 4bae53a into ceph:octopus Mar 2, 2022
@idryomov idryomov deleted the wip-rbd-qemu-iotests-8stream-octopus branch March 2, 2022 10:49
@cbodley
Copy link
Contributor

cbodley commented Mar 2, 2022

@idryomov what i see from the build log is that it wants to install focal's normal gcc version: gcc is already the newest version (4:9.3.0-1ubuntu2), but cmake selects gcc11: The CXX compiler identification is GNU 11.1.0

i'm guessing that this may be a side effect of my testing in #45133, where install-deps.sh enables the PPA repo and calls update-alternatives to select gcc 11. apologies if i've corrupted some build nodes this way :(

i think update-alternatives --remove-all gcc would resolve this, if we can find someone with access to these machines

and maybe our install-deps.sh, in the non-PPA case, should be running that command as well? i pushed a commit that does this to https://github.com/cbodley/ceph/commits/wip-install-deps-undo-ppa - if you're blocked on this in the future, you might try pulling that into the PR? once @djgalloway is back, we can figure out a better way to manage this between release branches

@idryomov
Copy link
Contributor Author

idryomov commented Mar 2, 2022

We will try it if it comes up again. Not all build nodes are affected -- I have seen it get past those SPDK errors in some PRs. Thanks, @cbodley!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants