Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGW - Fix inverted return check #45225

Merged
merged 1 commit into from Mar 7, 2022
Merged

RGW - Fix inverted return check #45225

merged 1 commit into from Mar 7, 2022

Conversation

dang
Copy link
Contributor

@dang dang commented Mar 2, 2022

get_obj_head_ioctx() returns the standard int but the call was casting
it to a bool, inverting it's meaning. Fix it to act correctly.

Fixes: https://tracker.ceph.com/issues/54452
Signed-off-by: Daniel Gryniewicz dang@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@dang dang added the rgw label Mar 2, 2022
@dang dang requested a review from ivancich March 2, 2022 18:04
@dang
Copy link
Contributor Author

dang commented Mar 3, 2022

jenkins test make check

@cbodley cbodley added the needs-quincy-backport backport required for quincy label Mar 3, 2022
@dang
Copy link
Contributor Author

dang commented Mar 3, 2022

https://pulpito.ceph.com/dang-2022-03-03_10:03:29-rgw-wip-dang-fix-inverted-distro-default-smithi/

@dang
Copy link
Contributor Author

dang commented Mar 3, 2022

jenkins test make check

@dang
RGW - Fix inverted return check
988c09d 
get_obj_head_ioctx() returns the standard int but the call was casting
it to a bool, inverting it's meaning.  Fix it to act correctly.

Fixes: https://tracker.ceph.com/issues/54452
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
@ljflores
Copy link
Contributor

ljflores commented Mar 5, 2022

jenkins test make check

@dang dang merged commit d9ac8f2 into ceph:master Mar 7, 2022
@dang dang deleted the wip-dang-fix-inverted branch March 9, 2022 15:11
@dang dang mentioned this pull request Mar 9, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivancich ivancich ivancich approved these changes

Assignees
No one assigned
Labels
needs-qa needs-quincy-backport backport required for quincy rgw
Projects
None yet
Milestone
No milestone
4 participants
@dang @ljflores @ivancich @cbodley