Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: RGW - Fix inverted return check #45315

Merged
merged 1 commit into from Mar 18, 2022
Merged

quincy: RGW - Fix inverted return check #45315

merged 1 commit into from Mar 18, 2022

Conversation

dang
Copy link
Contributor

@dang dang commented Mar 9, 2022

Backport #45225 to quincy

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@dang
RGW - Fix inverted return check
c456668 
get_obj_head_ioctx() returns the standard int but the call was casting
it to a bool, inverting it's meaning.  Fix it to act correctly.

Fixes: https://tracker.ceph.com/issues/54452
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
(cherry picked from commit 988c09d)
@dang dang added the rgw label Mar 9, 2022
@github-actions github-actions bot added this to the quincy milestone Mar 9, 2022
@idryomov
Copy link
Contributor

jenkins test windows

@yuriw
Copy link
Contributor

yuriw commented Mar 17, 2022

jenkins test api

@yuriw yuriw merged commit 622a1fb into ceph:quincy Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees
No one assigned
Labels
needs-qa rgw wip-yuri2-testing
Projects
None yet
Milestone
quincy
4 participants
@dang @idryomov @yuriw @cbodley