octopus: ceph.spec.in: remove build directory at end of %install #45699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserong
force-pushed
the
wip-55099-octopus
branch
from
bf2b860
to
66869b6
Compare
|
That force push was just adding Conflicts info to the commit message |
|
This also needs #45705 |
tchaikov
approved these changes
Apr 6, 2022
|
jenkins test docs please |
1 similar comment
|
jenkins test docs please |
hi Tim, the doc build failure should be addressed by #45972. before it is merged, i think we need to live with the build failure =( |
|
jenkins retest this please |
tserong
force-pushed
the
wip-55099-octopus
branch
from
ca39e92
to
0757786
Compare
|
Rebased to pick up docs fix |
|
Dammit, now it's failing API tests because "apache-libcloud 3.5.1 requires requests>=2.26.0, but you have requests 2.25.1 which is incompatible." |
By the time we get to the end of the %install section, all the built binaries have been installed in the build root, so we can delete the build directory from the source tree. This frees up about 17GB of disk space on build hosts, which is helpful in case other processes later in the RPM build need more disk space. Fixes: https://tracker.ceph.com/issues/55079 Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit aa18cb1) Conflicts: ceph.spec.in - octopus uses "build", not "%{_vpath_builddir}"
Removing the build directory at the end of %install is too soon, and means we get rid of a bunch of stuff needed to correctly create debuginfo/debugsource packages, which happens automatically right after %install. So, let's put it where it really belongs, in the %clean section. Fixes: aa18cb1 Fixes: https://tracker.ceph.com/issues/55079 Signed-off-by: Tim Serong <tserong@suse.com> (cherry picked from commit 94ad178)
tserong
force-pushed
the
wip-55099-octopus
branch
from
0757786
to
bba2708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/55099
backport of #45664
parent tracker: https://tracker.ceph.com/issues/55079
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh