Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quincy: mgr/dashboard: Table columns hiding fix #45724

Merged
merged 1 commit into from
May 31, 2022
Merged

quincy: mgr/dashboard: Table columns hiding fix #45724

merged 1 commit into from
May 31, 2022

Conversation

nizamial09
Copy link
Member

backport tracker: https://tracker.ceph.com/issues/54996

backport of #45269
parent tracker: https://tracker.ceph.com/issues/51119

this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh

@kalaspuffar @nizamial09
mgr/dashboard: switch the columns on and off correctly.
3b2089b 
Fixing the table model so it we can switch the columns on and off correctly.
A bug in the function tranfering the user configured columns made them
not tranfer over to the local displayed column list.

Fixes: http://tracker.ceph.com/issues/51119
Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
(cherry picked from commit 7ea0eb7)
@nizamial09 nizamial09 requested a review from a team as a code owner March 31, 2022 07:10
@nizamial09 nizamial09 requested review from pereman2 and Sarthak0702 and removed request for a team March 31, 2022 07:10
@nizamial09 nizamial09 added this to the quincy milestone Mar 31, 2022
@nizamial09 nizamial09 changed the title quincy: mgr/dashboard: Table columns hiding fix quincy: mgr/dashboard: Table columns hiding fix Mar 31, 2022
@nizamial09 nizamial09 added the backport: no-conflicts Backport without conflicts label Mar 31, 2022
@nizamial09
Copy link
Member Author

jenkins test dashboard

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@nizamial09
Copy link
Member Author

jenkins test dashboard cephadm

@epuertat
Copy link
Member

jenkins test docs

@epuertat
Copy link
Member

jenkins test dashboard

@epuertat epuertat merged commit bbbdc83 into ceph:quincy May 31, 2022
@epuertat epuertat deleted the wip-54996-quincy branch May 31, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pereman2 pereman2 pereman2 approved these changes

@epuertat epuertat epuertat approved these changes

@Sarthak0702 Sarthak0702 Sarthak0702 approved these changes

@aaSharma14 aaSharma14 Awaiting requested review from aaSharma14

@avanthakkar avanthakkar Awaiting requested review from avanthakkar

Assignees
No one assigned
Labels
backport: no-conflicts Backport without conflicts dashboard pybind
Projects
Ceph-Dashboard
Archived in project
Milestone
quincy
Development

Successfully merging this pull request may close these issues.
5 participants
@nizamial09 @epuertat @pereman2 @Sarthak0702 @kalaspuffar