quincy: cmake: WITH_SYSTEM_UTF8PROC defaults to OFF #45766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change the default value of WITH_SYSTEM_UTF8PROC from ON to OFF, so that centos/rhel users can build with the default cmake configuration. no other WITH_SYSTEM_* variable in ceph defaults to ON, so this is consistent with other bundled libraries like boost and rocksdb unfortunately, this also means that users that do have system packages must opt-in to using them with -DWITH_SYSTEM_UTF8PROC=ON both deb and rpm builds dependended on the previous default value, so their logic was negated to match the new default Fixes: https://tracker.ceph.com/issues/55114 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 90662ca)
ljflores
approved these changes
Apr 4, 2022
|
jenkins test docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/55175
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows