Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/cephadm: fixing logging output for rm-cluster operation #45931

Merged
merged 1 commit into from Apr 22, 2022

Conversation

rkachach
Copy link
Contributor

Let's use the recently added support to configure cephadm output (when using as standard binary) for rm-cluster operation also. This way user will see warnings/errors generated during this op.

Fixes: https://tracker.ceph.com/issues/51671
Signed-off-by: Redouane Kachach rkachach@redhat.com

Related PRs:
#45685

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

@rkachach rkachach requested a review from a team as a code owner April 18, 2022 13:45
src/cephadm/cephadm Outdated Show resolved Hide resolved
@adk3798
Copy link
Contributor

adk3798 commented Apr 22, 2022

https://pulpito.ceph.com/adking-2022-04-22_01:18:37-orch:cephadm-wip-adk-testing-2022-04-21-1828-distro-basic-smithi/

2 Failures inferring config in tests using docker, caused by another PR in the run.

@adk3798 adk3798 merged commit 413df90 into ceph:master Apr 22, 2022
@rkachach rkachach deleted the fix_issue_51671 branch April 27, 2022 08:13
@adk3798 adk3798 mentioned this pull request Apr 27, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants