quincy: cmake/rgw: add missing dependency on Arrow::Arrow #46144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when WITH_SYSTEM_ARROW is disabled, BuildArrow.cmake creates an Arrow::Parquet target that depends on Arrow::Arrow: target_link_libraries(Arrow::Parquet INTERFACE Arrow::Arrow) but when WITH_SYSTEM_ARROW is enabled, the targets we get from find_package() do not carry this dependency. so rgw's cmake needs to depend on both targets Fixes: https://tracker.ceph.com/issues/55420 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 3f12d21)
ivancich
approved these changes
May 9, 2022
|
jenkins test make check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/55545
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows