quincy: mgr/dashboard: WDC multipath bug fixes #46455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Physical Disks page, the uids for multiple devices are coming in as same and that causes the selection to go berserk and select multiple rows with same UID. The uid is generated in the frontend service call itself. I just added some more parameters to it inorder to make it more unique. The second issue is the number of selected number getting multiplied exponentially. Its because each time the table is updated or refreshed, we push the row with the number of selected items we had before and that causes the number of selection to multiply. Fixes: https://tracker.ceph.com/issues/55523 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit 9fe18a6)
nizamial09
requested review from
nSedrickm and
avanthakkar
and removed request for
a team
the error in the log was this
```
"/usr/share/ceph/mgr/dashboard/services/ceph_service.py", line 253, in _get_smart_data_by_device
May 06 07:38:39 occldlr750-1.occl208.lab conmon[2142938]: svc_type, svc_id = daemon.split('.')
May 06 07:38:39 occldlr750-1.occl208.lab conmon[2142938]: ValueError: too many values to unpack (expected 2)
```
on the cluster, the output of `ceph device ls-by-host` looks like this
```
ceph: root@occldlr750-1 /]# ceph device ls-by-host occldlr750-1.occl208.lab
DEVICE DEV DAEMONS EXPECTED FAILURE
DELLBOSS_VD_cbd004c975390010 sda mon.occldlr750-1.occl208.lab
WDC_WUH721818AL5204_3FGZR3JT sdda osd.20
WDC_WUH721818AL5204_3FH4315T sdbf osd.94
WDC_WUH721818AL5204_3FHP58TT sdec osd.30
WDC_WUH721818AL5204_3FHSK8HT sdu osd.78
WDC_WUH721818AL5204_3FHVTS9T sdfi osd.47
WDC_WUH721818AL5204_3FHWJE8T sdv osd.23
WDC_WUH721818AL5204_3FHXHETT sdcl osd.11
WDC_WUH721818AL5204_3FHXKP1T sdcj osd.10
```
the first device is mon and its name is mon.occldlr750-1.occl208.lab.
In our dashboard code, when fetching the smart data we have a line like
this
`svc_type, svc_id = daemon.split('.')`
so for the mon the output of `daemon.split('.') will be ['mon', 'occldlr750-1', 'occl208', 'lab']. The svc_id gets split into three because of the split. I am changing that and giving the criteria as splitting only on the first occurence of the dot and the considering everything that comes after the dot as the svc_id of the device.
Fixes: https://tracker.ceph.com/issues/55571
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit f38e3e9)
In the dashboard, we've been showing smart data for hdd devices with ata protocol only. Otherwise we show a No Smart Data found error which is clearly misleading since Smart Data is returned even in the api call. So this PR is trying to show the smart data for hdd devices that uses scsi protocol too. Fixes: https://tracker.ceph.com/issues/55574 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit 4fab663)
Fixes: https://tracker.ceph.com/issues/47218 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit ee78b47)
nizamial09
changed the title
avanthakkar
approved these changes
May 31, 2022
|
Adding no-conflicts label since based on the commit messages, no conflicts had to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/55589
backport tracker: https://tracker.ceph.com/issues/55598
backport tracker: https://tracker.ceph.com/issues/55593
backport tracker: https://tracker.ceph.com/issues/55591
backport of #46174
backport of #46196
backport of #46196
backport of #46201
parent tracker: https://tracker.ceph.com/issues/55523
parent tracker: https://tracker.ceph.com/issues/55571
parent tracker: https://tracker.ceph.com/issues/55574
parent tracker: https://tracker.ceph.com/issues/47218
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/master/src/script/ceph-backport.sh