quincy: mgr/dashboard: rbd image pagination #47104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pereman2
requested review from
melissa-kun-li and
Pegonzal
and removed request for
a team
pereman2
force-pushed
the
wip-56563-quincy
branch
from
179fe4c
to
65cef49
Compare
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit efd9a8b)
Count won't be used unless externalPaging is set to true. remove paginated import task list service needed to be updated in order to have extra params. This commit introduces that param. Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit dbf2552)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 78523ec)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 27f4051)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 4060061)
Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit a27eea3)
X-Total-Count header was missing from rbdservice.list spy mock Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 08b6f22)
- Disable sorting in each column because it will not be possible to sort with this pagination implementation. - Add search capabilities to the rbd list pagination endpoint. Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 68ef0b8)
Whenever we use serverSide (paginate through backend) we should debounce reloadData since it might call api calls too much times. Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit c832464)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 5386dd1)
Support sorting with name, pool name and namespace Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 3c30880) Conflict: - src/pybind/mgr/dashboard/services/rbd.py remove _rbd_image_stat_parent function because it doesn't exist in quincy.
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 9086917)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit c01ce41)
Image contexts are reopen even though we pass the context as an argument. This commit changes that so you can forget about reopening a rbd image context again. Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 5a0ead8)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 23615b3)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 08c980e)
Signed-off-by: Pere Diaz Bou <pdiazbou@redhat.com> (cherry picked from commit 80964fb)
pereman2
force-pushed
the
wip-56563-quincy
branch
from
65cef49
to
110b099
Compare
|
jenkins retest this please |
|
jenkins test make check |
Pegonzal
approved these changes
Aug 16, 2022
nizamial09
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/56563
backport of #46644
parent tracker: https://tracker.ceph.com/issues/56081