FileStore: sync object_map when we syncfs #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
|
Indeed, updating and retesting. |
This way, even if leveldb/rocksdb is on another filesystem/disk, it will still be synced before trimming the journal. Note, this patch only syncs the object_map in the !backend->can_checkpoint() case since if the backend can checkpoint, the checkpoint must also capture the object_map since we have not been setting replay guards in the object_map. Signed-off-by: Samuel Just <sjust@redhat.com>
athanatos
pushed a commit
that referenced
this pull request
Jun 4, 2015
FileStore: sync object_map when we syncfs Reviewed-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, even if leveldb/rocksdb is on another filesystem/disk,
it will still be synced before trimming the journal. Note, this
patch only syncs the object_map in the !backend->can_checkpoint()
case since if the backend can checkpoint, the checkpoint must
also capture the object_map since we have not been setting replay
guards in the object_map.
Signed-off-by: Samuel Just sjust@redhat.com