osd/scrub: verify SnapMapper consistency #47388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronen-fr
force-pushed
the
wip-rf-snapper
branch
2 times, most recently
from
3b11e17
to
6a38c0c
Compare
Matan-B
reviewed
Aug 1, 2022
ronen-fr
force-pushed
the
wip-rf-snapper
branch
3 times, most recently
from
6652b79
to
7b7ece5
Compare
athanatos
previously requested changes
Aug 2, 2022
There was a problem hiding this comment.
Seems to be heading in the right direction.
We have tests that inject errors and validate the scrub behaves correctly. We need to add these scenarios to those tests. Particularly, we want a test scenario that does a good job of mimicing the SNA_ removal upgrade bug situation.
ronen-fr
force-pushed
the
wip-rf-snapper
branch
from
7b7ece5
to
aafb8e6
Compare
ronen-fr
force-pushed
the
wip-rf-snapper
branch
10 times, most recently
from
3269d12
to
3d50361
Compare
ronen-fr
force-pushed
the
wip-rf-snapper
branch
from
3d50361
to
38b0098
Compare
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Whenever the scrubber access the SnapMapper for the snaps of a specific clone, the mapper will now verify that the snaps have the required mapping DB entries (the 'SNA_' keys). Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
The test (in the standalone/scrub suite) verifies that the scrubber
detects (and issues a cluster-log error) whenever a mapping entry
("SNA_") is missing in the SnapMapper DB.
Specifically, here the entry is corrupted - shortened as per
https://tracker.ceph.com/issues/56147.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
... systematically, over ceph::bufferlist. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
force-pushed
the
wip-rf-snapper
branch
from
944796e
to
a85ef8e
Compare
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
|
Merging based on Teu results (see above) |
|
It looks like this never got backported to any release. Am I correct, and if so shouldn't it be? |
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
A manual backport of the relevant changes introduced in PR ceph#47388 (osd/scrub: verify SnapMapper consistency) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
encountered when manually backporting PR ceph#47388. Mostly fmtlib-related. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
updating the standalone tests to match the exact format of some log lines. A manual backport of PR ceph#47388. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
A manual backport of the relevant changes introduced in PR ceph#47388 (osd/scrub: verify SnapMapper consistency) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
updating the standalone tests to match the exact format of some log lines. A manual backport of PR ceph#47388. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
A manual backport of the relevant changes introduced in PR ceph#47388 (osd/scrub: verify SnapMapper consistency) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
updating the standalone tests to match the exact format of some log lines. A manual backport of PR ceph#47388. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
A manual backport of the relevant changes introduced in PR ceph#47388 (osd/scrub: verify SnapMapper consistency) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
updating the standalone tests to match the exact format of some log lines. A manual backport of PR ceph#47388. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
A manual backport of the relevant changes introduced in PR ceph#47388 (osd/scrub: verify SnapMapper consistency) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
The test (in the standalone/scrub suite) verifies that the scrubber
detects (and issues a cluster-log error) whenever a mapping entry
("SNA_") is missing in the SnapMapper DB.
Specifically, here the entry is corrupted - shortened as per
https://tracker.ceph.com/issues/56147.
A manual backport of PR ceph#47388.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
encountered when manually backporting PR ceph#47388. Mostly fmtlib-related. Probably related to installed FMT-lib version. All changes copied from 'main'. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
updating the standalone tests to match the exact format of some log lines. A manual backport of PR ceph#47388. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
A manual backport of the relevant changes introduced in PR ceph#47388 (osd/scrub: verify SnapMapper consistency) Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 25, 2023
The test (in the standalone/scrub suite) verifies that the scrubber
detects (and issues a cluster-log error) whenever a mapping entry
("SNA_") is missing in the SnapMapper DB.
Specifically, here the entry is corrupted - shortened as per
https://tracker.ceph.com/issues/56147.
A manual backport of PR ceph#47388.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 28, 2023
encountered when manually backporting PR ceph#47388. Mostly fmtlib-related. Probably related to installed FMT-lib version. All changes copied from 'main'. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 29, 2023
encountered when manually backporting PR ceph#47388. Mostly fmtlib-related. Probably related to installed FMT-lib version. All changes copied from 'main'. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
ronen-fr
added a commit
to ronen-fr/ceph
that referenced
this pull request
Jun 29, 2023
encountered when manually backporting PR ceph#47388. Mostly fmtlib-related. Probably related to installed FMT-lib version. All changes copied from 'main'. Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the scrubber accesses the SnapMapper for the snaps of a specific
clone, the mapper will now verify that the snaps have the required
mapping DB entries (the 'SNA_' keys).
Signed-off-by: Ronen Friedman rfriedma@redhat.com