quincy: include: fix IS_ERR on Windows #47922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "long" type uses 32b on x64 Windows platforms, which means it's not large enough to store a pointer. intptr_t or uintptr_t should be used instead. This change fixes include/err.h, using the right types. There was a previous patch on this topic but unfortunately it didn't address all the type casts. This issue was brought up by the unittest_crush test, which recently started to fail as the CrushWrapper methods use IS_ERR. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com> (cherry picked from commit c95b6b6)
idryomov
approved these changes
Sep 3, 2022
|
|
idryomov
added
bug-fix
needs-qa
win32
|
The commit has been included here #48016, I think we can close this PR. |
|
Yup, I will update the backport tracker accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/57402
backport of #47818
parent tracker: https://tracker.ceph.com/issues/57308
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh