New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include: fix IS_ERR on Windows #47818
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrutlucian94
force-pushed
the
fix_is_err
branch
from
August 26, 2022 13:15
771854d
to
555ee08
Compare
jenkins test windows |
idryomov
reviewed
Aug 26, 2022
petrutlucian94
force-pushed
the
fix_is_err
branch
from
August 27, 2022 05:58
555ee08
to
e480f74
Compare
idryomov
reviewed
Aug 27, 2022
The "long" type uses 32b on x64 Windows platforms, which means it's not large enough to store a pointer. intptr_t or uintptr_t should be used instead. This change fixes include/err.h, using the right types. There was a previous patch on this topic but unfortunately it didn't address all the type casts. This issue was brought up by the unittest_crush test, which recently started to fail as the CrushWrapper methods use IS_ERR. Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
petrutlucian94
force-pushed
the
fix_is_err
branch
from
August 27, 2022 09:17
e480f74
to
c95b6b6
Compare
idryomov
approved these changes
Aug 27, 2022
jenkins test make check |
jenkins test windows |
jenkins test make check arm64 |
1 similar comment
jenkins test make check arm64 |
14 tasks
This was referenced Sep 2, 2022
@djgalloway FWIW this had a pending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
include: fix IS_ERR on Windows
The "long" type uses 32b on x64 Windows platforms, which means
it's not large enough to store a pointer. intptr_t or uintptr_t
should be used instead.
This change fixes include/err.h, using the right types. There was
a previous patch on this topic but unfortunately it didn't address
all the type casts.
This issue was brought up by the unittest_crush test, which recently
started to fail as the CrushWrapper methods use IS_ERR.
Fixes: https://tracker.ceph.com/issues/57308
Signed-off-by: Lucian Petrut lpetrut@cloudbasesolutions.com
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows