Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: test/{librbd, rgw}: increase delay between and number of bind attempts #48024

Merged
merged 2 commits into from Sep 9, 2022
Merged

pacific: test/{librbd, rgw}: increase delay between and number of bind attempts #48024

merged 2 commits into from Sep 9, 2022

Conversation

idryomov
Copy link
Contributor

@idryomov idryomov commented Sep 8, 2022

tchaikov and others added 2 commits September 8, 2022 21:18
@tchaikov @idryomov
test/{librbd, rgw}: retry when bind fail with port 0
9556c08 
there is chance that the bind() call may fail if we have another test
happen to pick the free port picked by operating system. in this case,
we just retry up to 42 times.

in theory, this change does not fully address the racing, but it should
help to alleviate this issue.

See-also: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit aa7885f)

Conflicts:
	src/test/rgw/test_http_manager.cc [ commit f5019d2 ("rgw:
	  Set CURLOPT_NOBODY for HEAD request") not in pacific ]
@idryomov
test/{librbd, rgw}: increase delay between and number of bind attempts
a7fec02 
Commit aa7885f ("test/{librbd, rgw}: retry when bind fail with
port 0") reduced the frequency of sporadic unit test failures caused
by EADDRINUSE a lot, but not entirely.

Currently, it yields a cumulative sleep of ~9 seconds.  Let's increase
that to 1 minute.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 48016ea)
@idryomov idryomov added this to the pacific milestone Sep 8, 2022
@idryomov idryomov requested a review from a team as a code owner September 8, 2022 19:24
@idryomov
Copy link
Contributor Author

idryomov commented Sep 9, 2022 •
edited 

[ RUN      ] DecayCounter.steady
t 799.389 e 811.18
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/common/test_counter.cc:39: Failure
Expected: (std::abs(total-expected)/expected) < (0.01), actual: 0.0145363 vs 0.01
[  FAILED  ] DecayCounter.steady (2004 ms)
[----------] 1 test from DecayCounter (2004 ms total)

The following tests FAILED:
	 65 - unittest_counter (Failed)

Opened #48031 for that.

@idryomov
Copy link
Contributor Author

idryomov commented Sep 9, 2022

jenkins test make check

@idryomov idryomov merged commit b39c199 into ceph:pacific Sep 9, 2022
@idryomov idryomov deleted the wip-57116-cont-pacific branch September 9, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljflores ljflores ljflores approved these changes

@cbodley cbodley Awaiting requested review from cbodley

Assignees
No one assigned
Labels
rbd rgw tests
Projects
None yet
Milestone
pacific
3 participants
@idryomov @ljflores @tchaikov