Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pacific: test/{librbd, rgw}: increase delay between and number of bind attempts #48024

Merged
merged 2 commits into from Sep 9, 2022
Merged

pacific: test/{librbd, rgw}: increase delay between and number of bind attempts #48024

merged 2 commits into from Sep 9, 2022

Commits on Sep 8, 2022

  1. test/{librbd, rgw}: retry when bind fail with port 0 

    there is chance that the bind() call may fail if we have another test
happen to pick the free port picked by operating system. in this case,
we just retry up to 42 times.

in theory, this change does not fully address the racing, but it should
help to alleviate this issue.

See-also: https://tracker.ceph.com/issues/57116
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit aa7885f)

Conflicts:
	src/test/rgw/test_http_manager.cc [ commit f5019d2 ("rgw:
	  Set CURLOPT_NOBODY for HEAD request") not in pacific ]
    @tchaikov @idryomov
    tchaikov authored and idryomov committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    9556c08 View commit details
    Browse the repository at this point in the history

  2. test/{librbd, rgw}: increase delay between and number of bind attempts 

    Commit aa7885f ("test/{librbd, rgw}: retry when bind fail with
port 0") reduced the frequency of sporadic unit test failures caused
by EADDRINUSE a lot, but not entirely.

Currently, it yields a cumulative sleep of ~9 seconds.  Let's increase
that to 1 minute.

Fixes: https://tracker.ceph.com/issues/57116
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 48016ea)
    @idryomov
    idryomov committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    a7fec02 View commit details
    Browse the repository at this point in the history