-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cephfs-top: make cephfs-top display scrollable #48090
Conversation
80de4e3
to
684a45c
Compare
a0beb62
to
a7ed3e1
Compare
a7ed3e1
to
9ef4005
Compare
ff6408d
to
5493030
Compare
5493030
to
2c9f1ac
Compare
jenkins test api |
0ee2aa1
to
fbdd127
Compare
jenkins test api |
1 similar comment
jenkins test api |
Fixes: https://tracker.ceph.com/issues/55197 Signed-off-by: Jos Collin <jcollin@redhat.com>
Fixes: https://tracker.ceph.com/issues/55197 Signed-off-by: Jos Collin <jcollin@redhat.com>
* drop the blank FS Menu when there is no FS * cleanup display_fs_menu() code Signed-off-by: Jos Collin <jcollin@redhat.com>
fbdd127
to
a386400
Compare
jenkins test windows |
1 similar comment
jenkins test windows |
Waiting for an ACK from @neesingh-rh for merge. |
Now this delay blocks me from creating a new PR (rebased). @vshankar Can you approve instead? |
Well ok :) |
Fixes: https://tracker.ceph.com/issues/55197
Up/Down
Arrow Keys,PgUp/PgDn
Keys ormouse
for Vertical scrolling. UseLeft/Right
Arrow Keys andHome/End
keys for Horizontal scrolling.run_display
andrun_all_display
applications separately for customising, if needed.PAD_WIDTH
appropriately. Don't calculate the horizontal length anymore.PAD_HEIGHT
of 10,000, which means I'm expecting nearly 10,000 clients only. We could make it configurable or calculate it either (later). The important thing to notice is that thePAD_HEIGHT
andPAD_WIDTH
are constant with in the run display application. It could be configured, but it's not meant for changing dynamically. It's not meant for resizing and recreating dynamically. Create the pad once and use it until the end of the application. Only a portion of the viewport (clipping box) is refreshed at a time.To test this well, try great number of clients like:
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows