Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/mgr: fix tox autopep8 args flake8 #49505

Merged
merged 1 commit into from
Dec 19, 2022

Conversation

aaSharma14
Copy link
Contributor

Similar to mypy, we now need a backslash to signal a newline doesn't mean to start a new command

Follow up of: #49361

Signed-off-by: Aashish Sharma aasharma@redhat.com

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

Similar to mypy, we now need a backslash to signal
a newline doesn't mean to start a new command

Follow up of: ceph#49361

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
@pereman2 pereman2 merged commit a401f22 into ceph:quincy Dec 19, 2022
@pereman2 pereman2 deleted the fix-tox-flake8-check branch December 19, 2022 14:14
@tchaikov
Copy link
Contributor

in future, I'd suggest backport changes from main instead replicating them. If we have to, please note the reason why the change cannot be backported in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants