New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: MDSMonitor: handle MDSBeacon messages properly #5123

Merged
merged 4 commits into from Jul 8, 2015

Conversation

Projects
None yet
4 participants
@theanalyst
Member

theanalyst commented Jul 1, 2015

tchaikov added some commits Jun 2, 2015

mon: remove unnecessary error handling
msg.get_session() should always return a non-zero pointer in
Monitor.dispatch()

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 16e8e2c)
mon: send no_reply() to peon to drop ignored mdsbeacon
so the peon can remove the ignored mdsbeacon request from the
routed_requets at seeing this reply, and hence no longer resend the
request.

Fixes: #11590
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 72a37b3)
mon/MDSMonitor: rename labels to a better name
* s/ignore/reply/
* s/out/ignore/

Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit f00ecb8)
mon: always reply mdsbeacon
the MDS (Beacon) is always expecting the reply for the mdsbeacon messages from
the lead mon, and it uses the delay as a metric for the laggy-ness of the
Beacon. when it comes to the MDSMonitor on a peon, it will remove the route
session at seeing a reply (route message) from leader, so a reply to
mdsbeacon will stop the peon from resending the mdsbeacon request to the
leader.

if the MDSMonitor re-forwards the unreplied requests after they are
outdated, there are chances that the requests reflecting old and even wrong
state of the MDSs mislead the lead monitor. for example, the MDSs which sent
the outdated messages could be dead.

Fixes: #11590
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit b3555e9)

@theanalyst theanalyst self-assigned this Jul 1, 2015

@theanalyst theanalyst added this to the hammer milestone Jul 1, 2015

@theanalyst theanalyst assigned tchaikov and unassigned theanalyst Jul 1, 2015

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 1, 2015

Hi @tchaikov I've looked up on the original issue and added the corresponding pull requests (there were two) onto the backport. Does this look okay to you?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 2, 2015

@theanalyst LGTM, but i'm just wondering if we should also backport http://tracker.ceph.com/issues/11481 (#4658) to at least hammer. @gregsfortytwo and @jcsp what do you think? just checked 11481 is supposed to be backported to hammer.

@tchaikov tchaikov assigned theanalyst and unassigned tchaikov Jul 8, 2015

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jul 8, 2015

I've moved that ticket to the Pending Backport state, but there's no need for them to happen in the same PR.

gregsfortytwo added a commit that referenced this pull request Jul 8, 2015

Merge pull request #5123 from theanalyst/wip-11979-hammer
MDSMonitor: handle MDSBeacon messages properly

Reviewed-by: Kefu Chai <kchai@redhat.com>

@gregsfortytwo gregsfortytwo merged commit 6ffb1c4 into ceph:hammer Jul 8, 2015

@gregsfortytwo

This comment has been minimized.

Member

gregsfortytwo commented Jul 8, 2015

Sorry @theanalyst; I'm not sure what buttons I'm supposed to twiddle on the tracker so you'll have to do that. :)

@ghost ghost changed the title from MDSMonitor: handle MDSBeacon messages properly to mon: MDSMonitor: handle MDSBeacon messages properly Aug 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment