-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mon: MDSMonitor: handle MDSBeacon messages properly #5123
Conversation
msg.get_session() should always return a non-zero pointer in Monitor.dispatch() Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 16e8e2c)
so the peon can remove the ignored mdsbeacon request from the routed_requets at seeing this reply, and hence no longer resend the request. Fixes: ceph#11590 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 72a37b3)
* s/ignore/reply/ * s/out/ignore/ Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit f00ecb8)
the MDS (Beacon) is always expecting the reply for the mdsbeacon messages from the lead mon, and it uses the delay as a metric for the laggy-ness of the Beacon. when it comes to the MDSMonitor on a peon, it will remove the route session at seeing a reply (route message) from leader, so a reply to mdsbeacon will stop the peon from resending the mdsbeacon request to the leader. if the MDSMonitor re-forwards the unreplied requests after they are outdated, there are chances that the requests reflecting old and even wrong state of the MDSs mislead the lead monitor. for example, the MDSs which sent the outdated messages could be dead. Fixes: ceph#11590 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit b3555e9)
Hi @tchaikov I've looked up on the original issue and added the corresponding pull requests (there were two) onto the backport. Does this look okay to you? |
@theanalyst LGTM, |
I've moved that ticket to the Pending Backport state, but there's no need for them to happen in the same PR. |
MDSMonitor: handle MDSBeacon messages properly Reviewed-by: Kefu Chai <kchai@redhat.com>
Sorry @theanalyst; I'm not sure what buttons I'm supposed to twiddle on the tracker so you'll have to do that. :) |
http://tracker.ceph.com/issues/11979