python-common/drive_group: handle fields outside of 'spec' even when 'spec' is provided

[adk3798]

Otherwise certain specs such as

service_type: osd
service_id: xxx
service_name: osd.xxx
placement:
  hosts:
  - vm-00 spec:
  osds_per_device: 2
data_devices:
  paths:
  - /dev/vde

fail to apply with

Error EINVAL: ServiceSpec: 'dict' object has no attribute 'validate'

which is not a useful error message. This is caused by the spec assuming all osd specific fields are either defined in the 'spec' section or outside of it, but not mixed in. We could also just consider these specs to be invalid and just raise a better error message, but it seems easier to make the minor adjustment for it to work, given there doesn't seem to be an issue with mixing the styles for specs for other service types.

Fixes: https://tracker.ceph.com/issues/61533

Contribution Guidelines

• To sign and title your commits, please refer to Submitting Patches to Ceph.

• If you are submitting a fix for a stable branch (e.g. "pacific"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

Checklist

• Tracker (select at least one)
  • References tracker ticket
  • Very recent bug; references commit where it was introduced
  • New feature (ticket optional)
  • Doc update (no ticket needed)
  • Code cleanup (no ticket needed)
• Component impact
  • Affects Dashboard, opened tracker ticket
  • Affects Orchestrator, opened tracker ticket
  • No impact that needs to be tracked
• Documentation (select at least one)
  • Updates relevant documentation
  • No doc update is appropriate
• Tests (select at least one)
  • Includes unit test(s)
  • Includes integration test(s)
  • Includes bug reproducer
  • No tests

Show available Jenkins commands

• jenkins retest this please
• jenkins test classic perf
• jenkins test crimson perf
• jenkins test signed
• jenkins test make check
• jenkins test make check arm64
• jenkins test submodules
• jenkins test dashboard
• jenkins test dashboard cephadm
• jenkins test api
• jenkins test docs
• jenkins render docs
• jenkins test ceph-volume all
• jenkins test ceph-volume tox
• jenkins test windows

[phlogistonjohn]

LGTM.
I personally don't like how "loose" these yaml specs are in general, but that's how they are and consistency is good.

[adk3798]

https://pulpito.ceph.com/adking-2023-06-13_16:39:13-orch:cephadm-wip-adk-testing-2023-06-13-1036-distro-default-smithi/

Reruns of failed/dead jobs (some also marked still "running" in the original run at the time of writing this, due to the original ansible to set up the node not completing): https://pulpito.ceph.com/adking-2023-06-14_12:47:06-orch:cephadm-wip-adk-testing-2023-06-13-1036-distro-default-smithi/

After reruns, 2 failures:

• 1 timeout in test_nfs test with the agent on, known issue that pops up occasionally
• 1 failure deploying jaeger-tracing, known issue - https://tracker.ceph.com/issues/59704

Nothing there to block merging