pacific: python-common/drive_group: handle fields outside of 'spec' even when 'spec' is provided #52413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…'spec' is provided Otherwise certain specs such as service_type: osd service_id: xxx service_name: osd.xxx placement: hosts: - vm-00 spec: osds_per_device: 2 data_devices: paths: - /dev/vde fail to apply with Error EINVAL: ServiceSpec: 'dict' object has no attribute 'validate' which is not a useful error message. This is caused by the spec assuming all osd specific fields are either defined in the 'spec' section or outside of it, but not mixed in. We could also just consider these specs to be invalid and just raise a better error message, but it seems easier to make the minor adjustment for it to work, given there doesn't seem to be an issue with mixing the styles for specs for other service types. Fixes: https://tracker.ceph.com/issues/61533 Signed-off-by: Adam King <adking@redhat.com> (cherry picked from commit 12901f6)
adk3798
force-pushed
the
wip-61686-pacific
branch
from
4dc3f09
to
971800e
Compare
guits
approved these changes
Jul 19, 2023
|
reruns of failed jobs: https://pulpito.ceph.com/adking-2023-10-12_22:09:36-orch:cephadm-wip-adk2-testing-2023-10-11-1434-pacific-distro-default-smithi/ reruns of reruns of failed jobs: https://pulpito.ceph.com/adking-2023-10-13_12:25:25-orch:cephadm-wip-adk2-testing-2023-10-11-1434-pacific-distro-default-smithi/ Needed double reruns because we were hitting a combination of and failures. After the second rerun, 3 failures:
Nothing new or that should block merging for the backports in the run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/61686
backport of #51861
parent tracker: https://tracker.ceph.com/issues/61533
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh