rgw/amqp: remove possible race conditions with the amqp connections #52110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify memory management of the connection by not using a unique_ptr * simplify the logic by handling all issues inside the amqp manager * fix iterator invalidation issue with miltiple n/acks * allow different connections with different exchanges * modify the unit tests according to the new behavior Fixes: * https://tracker.ceph.com/issues/61639 * https://tracker.ceph.com/issues/46127 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
cbodley
approved these changes
Jun 22, 2023
src/rgw/rgw_amqp.cc
Outdated
| }; | ||
|
|
||
| std::string to_string(const connection_id_t& id) { | ||
| return id.host+":"+std::to_string(id.port)+id.vhost; | ||
| return std::string("amqp")+(id.ssl ? "s" : "")+"://"+id.host+":"+std::to_string(id.port)+id.vhost+"?exchange="+id.exchange; |
There was a problem hiding this comment.
probably worth using fmt::format() to clean this up. string::operator+ which can be expensive if we can't fit everything in the short string optimization, as each operator+ could end up reallocating
return fmt::format("{}://{}:{}{}?exchange={}",
id.ssl ? "amqps" : "amqp",
id.host, id.port, id.vhost, id.exchange);Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
yuvalif
force-pushed
the
wip-yuval-fix-61639
branch
from
6b2adfa
to
2e92331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows