reef: rgw/amqp: remove possible race conditions with the amqp connections #53516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
|
@yuvalif pls rebase |
* simplify memory management of the connection by not using a unique_ptr * simplify the logic by handling all issues inside the amqp manager * fix iterator invalidation issue with miltiple n/acks * allow different connections with different exchanges * modify the unit tests according to the new behavior Fixes: * https://tracker.ceph.com/issues/61639 * https://tracker.ceph.com/issues/46127 Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com> (cherry picked from commit 38d819b)
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com> (cherry picked from commit 2e92331)
yuvalif
force-pushed
the
wip-61919-reef
branch
from
26871a9
to
cfe2dfa
Compare
|
jenkins test api |
|
|
jenkins test api |
smanjara
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/61919
backport of #52110
parent tracker: https://tracker.ceph.com/issues/61639
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh